Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vbump teal.data #1194

Merged
merged 2 commits into from
Apr 8, 2024
Merged

vbump teal.data #1194

merged 2 commits into from
Apr 8, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Apr 8, 2024

fix verdepcheck pipelines - last built: https://github.com/insightsengineering/teal/actions/runs/8585966547

min_isolated fails with this:

  ── Error ('test-module_nested_tabs.R:4'): (code run outside of `test_that()`) ──
  Error in `.local(object, deparse, ...)`: unused argument (check_names = FALSE)
  Backtrace:
      ▆
   1. └─teal:::teal_data_to_filtered_data(teal_data) at test-module_nested_tabs.R:4:1
   2.   ├─teal.data::get_code(x, datanames = datanames, check_names = FALSE)
   3.   └─teal.data::get_code(x, datanames = datanames, check_names = FALSE)

check_names argument (supported via ...) is missing in 0.4.0 and it's there in 0.5.0

I will be running verdepcheck pipelines manually. You can check its status here: https://github.com/insightsengineering/teal/actions/workflows/scheduled.yaml?query=branch%3Afix_verdepcheck

@pawelru pawelru added the core label Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  36      25  30.56%   21-37, 40-47
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                             86      31  63.95%   108-115, 161-162, 164, 176-197, 228-229, 231
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     125  20.89%   42-43, 57-59, 70-83, 93-143, 148-149, 189, 224-301
R/module_filter_manager.R            84      19  77.38%   38-42, 157, 162-175
R/module_nested_tabs.R              161      60  62.73%   39-112, 128, 180, 202, 224, 232, 236
R/module_snapshot_manager.R         241     178  26.14%   95-107, 136-139, 143-144, 159-169, 173-188, 190-198, 205-220, 224-228, 230-236, 239-252, 255-273, 282-298, 313-336, 339-350, 353-359, 373, 394-418
R/module_tabs_with_filters.R         76      33  56.58%   33-68, 100, 116
R/module_teal_with_splash.R         114      34  70.18%   60-95, 110, 131, 197-198
R/module_teal.R                     110      76  30.91%   52-119, 150-151, 157, 168, 181-212
R/module_wunder_bar.R                60      39  35.00%   23-41, 55-64, 68-77
R/modules.R                         159      26  83.65%   127-130, 147-151, 206-209, 291-292, 344, 356-364, 418-421
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 19      19  0.00%    17-36
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    62       5  91.94%   69, 118-119, 122, 139
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   137-150
R/TealAppDriver.R                   271     271  0.00%    43-576
R/utils.R                           173       1  99.42%   255
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              12       8  33.33%   3-15
TOTAL                              2190    1045  52.28%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 5d02a54

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Unit Tests Summary

  1 files   30 suites   2m 53s ⏱️
240 tests 240 ✅ 0 💤 0 ❌
505 runs  505 ✅ 0 💤 0 ❌

Results for commit 5d02a54.

@pawelru pawelru merged commit 23ce975 into main Apr 8, 2024
29 checks passed
@pawelru pawelru deleted the fix_verdepcheck branch April 8, 2024 12:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants