Merge branch 'main' into fix_verdepcheck

DESCRIPTION

@@ -1,8 +1,8 @@
 Type: Package
 Package: teal
 Title: Exploratory Web Apps for Analyzing Clinical Trials Data
-Version: 0.15.2.9020
-Date: 2024-04-01
+Version: 0.15.2.9021
+Date: 2024-04-08
 Authors@R: c(
     person("Dawid", "Kaledkowski", , "[email protected]", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0001-9533-457X")),

NEWS.md

@@ -1,4 +1,4 @@
-# teal 0.15.2.9020
+# teal 0.15.2.9021
 
 ### Miscellaneous
 * Filter mapping display is no longer coupled to the snapshot manager.

R/TealAppDriver.R

@@ -237,15 +237,8 @@ TealAppDriver <- R6::R6Class( # nolint: object_name.
     #' @description
     #' Get the active datasets that can be accessed via the filter panel of the current active teal module.
     get_active_filter_vars = function() {
-      displayed_datasets_index <- unlist(
-        self$get_js(
-          sprintf(
-            "Array.from(
-                document.querySelectorAll(\"#%s-active-filter_active_vars_contents > span\")
-            ).map((el) => window.getComputedStyle(el).display != \"none\");",
-            self$active_filters_ns()
-          )
-        )
+      displayed_datasets_index <- self$is_visible(
+        sprintf("#%s-active-filter_active_vars_contents > span", self$active_filters_ns())
       )
 
       available_datasets <- self$get_text(
@@ -257,6 +250,35 @@ TealAppDriver <- R6::R6Class( # nolint: object_name.
       available_datasets[displayed_datasets_index]
     },
     #' @description
+    #' Test if `DOM` elements are visible on the page with a JavaScript call.
+    #' @param selector (`character(1)`) `CSS` selector to check visibility.
+    #' A `CSS` id will return only one element if the UI is well formed.
+    #' @param content_visibility_auto,opacity_property,visibility_property (`logical(1)`) See more information
+    #' on <https://developer.mozilla.org/en-US/docs/Web/API/Element/checkVisibility>.
+    #'
+    #' @return Logical vector with all occurrences of the selector.
+    is_visible = function(selector,
+                          content_visibility_auto = FALSE,
+                          opacity_property = FALSE,
+                          visibility_property = FALSE) {
+      checkmate::assert_string(selector)
+      checkmate::assert_flag(content_visibility_auto)
+      checkmate::assert_flag(opacity_property)
+      checkmate::assert_flag(visibility_property)
+      unlist(
+        self$get_js(
+          sprintf(
+            "Array.from(document.querySelectorAll('%s')).map(el => el.checkVisibility({%s, %s, %s}))",
+            selector,
+            # Extra parameters
+            sprintf("contentVisibilityAuto: %s", tolower(content_visibility_auto)),
+            sprintf("opacityProperty: %s", tolower(opacity_property)),
+            sprintf("visibilityProperty: %s", tolower(visibility_property))
+          )
+        )
+      )
+    },
+    #' @description
     #' Get the active filter variables from a dataset in the `teal` app.
     #'
     #' @param dataset_name (character) The name of the dataset to get the filter variables from.