-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R CMD CHECK note #288
Comments
Hey @llrs-roche, I have linked your PR as this essentially solves the issue but can you also have a look at the CI part so that it would be automatically captured by CI on commit (instead of external testing service) |
Oh, I didn't realize there was already an issue for this. |
That list is collapsed into one string with |
This PR is to add the notes to the CI part per #288 but only for teal.reporter. The changes do not look to the general issue as vignettes failing to build could be due to a number of reasons. As far as I know the string I added is specific for this error. To fix the issue PR #290 was already merge so I don't expect any failures now. This could be added to the default/general check from r.pkg.template if it meets the IDR requirements. --------- Signed-off-by: Lluís Revilla <[email protected]> Co-authored-by: Marcin <[email protected]>
# Pull Request Following insightsengineering/teal.reporter#288 this PR add this note as a blocking note. I added the note to several workflows (based on a [PR on other repositories](insightsengineering/teal.reporter#291)), let me know if this is a good approach. --------- Co-authored-by: Marcin <[email protected]>
The text was updated successfully, but these errors were encountered: