Skip to content

Commit

Permalink
Add a blocking note for missing VignetteBuilder engine (#275)
Browse files Browse the repository at this point in the history
# Pull Request

Following
insightsengineering/teal.reporter#288 this PR
add this note as a blocking note.

I added the note to several workflows (based on a [PR on other
repositories](insightsengineering/teal.reporter#291)),
let me know if this is a good approach.

---------

Co-authored-by: Marcin <[email protected]>
  • Loading branch information
llrs-roche and m7pr authored Feb 11, 2025
1 parent d203f27 commit 7cd266b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/build-check-install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ on:
checking for unstated dependencies in vignettes ... NOTE( )+\'.*\' import not declared from
checking dependencies in R code ... NOTE( )+Namespace in Imports field not imported from
checking installed package size ... NOTE( )+installed size is
checking files in ‘vignettes’ ... NOTE( )+VignetteBuilder field missing
required: false
default: ""
type: string
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/check.yaml.shared
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
checking Rd .usage sections .* NOTE
checking for unstated dependencies in vignettes .* NOTE
checking top-level files .* NOTE
checking files in ‘vignettes’ .* NOTE
r-cmd-non-cran:
name: R CMD Check (non-CRAN) 🧬
uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@main
Expand All @@ -58,6 +59,7 @@ jobs:
checking Rd .usage sections .* NOTE
checking for unstated dependencies in vignettes .* NOTE
checking top-level files .* NOTE
checking files in ‘vignettes’ .* NOTE
coverage:
name: Coverage 📔
uses: insightsengineering/r.pkg.template/.github/workflows/test-coverage.yaml@main
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release.yaml.shared
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:
checking examples .* NOTE
checking Rd line widths .* NOTE
checking top-level files .* NOTE
checking files in ‘vignettes’ .* NOTE
coverage:
name: Coverage 📔
needs: [release, docs]
Expand Down

0 comments on commit 7cd266b

Please sign in to comment.