Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect results in ping plugin #6581

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Fix incorrect results in ping plugin #6581

merged 2 commits into from
Nov 5, 2019

Conversation

glinton
Copy link
Contributor

@glinton glinton commented Oct 25, 2019

In the last change, sending to a channel was overlooked, causing all
ping errors and packet sent count to be ignored.

Resolves #6576

In the last change, sending to a channel was overlooked, causing all
ping errors and packet sent count to be ignored.
@glinton glinton added the fix pr to fix corresponding bug label Oct 25, 2019
@glinton glinton added this to the 1.12.5 milestone Oct 25, 2019
@glinton glinton requested a review from a team October 25, 2019 15:31
@ghost ghost requested review from reimda and removed request for a team October 25, 2019 15:32
@superjeng1
Copy link

I can confirm the debian amd64 version is working again. Thanks a lot!

@sjwang90 sjwang90 requested a review from goller November 4, 2019 18:43
@danielnelson danielnelson merged commit f0a5784 into master Nov 5, 2019
@danielnelson danielnelson deleted the bugfix/6576 branch November 5, 2019 18:34
danielnelson pushed a commit that referenced this pull request Nov 5, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native Ping not working after 1.12.4
5 participants