Fix incorrect results in ping plugin (influxdata#6581)

arstercz · Nov 5, 2019 · f0a5784 · f0a5784
1 parent 9efc376
commit f0a5784
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/plugins/inputs/ping/ping.go b/plugins/inputs/ping/ping.go
@@ -293,10 +293,12 @@ func (p *Ping) pingToURLNative(destination string, acc telegraf.Accumulator) {
 					if strings.Contains(err.Error(), "not permitted") {
 						sent.sent = false
 					}
+					sents <- sent
 					return
 				}
 
 				resps <- resp
+				sents <- sent
 			}(i + 1)
 		}
 	}

diff --git a/plugins/inputs/ping/ping_test.go b/plugins/inputs/ping/ping_test.go
@@ -355,4 +355,5 @@ func TestPingGatherNative(t *testing.T) {
 
 	assert.NoError(t, acc.GatherError(p.Gather))
 	assert.True(t, acc.HasPoint("ping", map[string]string{"url": "localhost"}, "packets_transmitted", 5))
+	assert.True(t, acc.HasPoint("ping", map[string]string{"url": "localhost"}, "packets_received", 5))
 }