Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.gnmi): Normalize path for inline origin handling #14838

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Feb 16, 2024

Summary

Cisco devices tend to send the origin as part of the first path-element instead of using the Origin! Fix the issue by normalizing the path after appending to extract the origin in this case.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14833

@telegraf-tiger telegraf-tiger bot added area/gnmi fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 16, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 19, 2024
@powersj
Copy link
Contributor

powersj commented Feb 20, 2024

Thanks for digging into this one!

@powersj powersj merged commit 8a83863 into influxdata:master Feb 20, 2024
25 of 26 checks passed
@github-actions github-actions bot added this to the v1.29.5 milestone Feb 20, 2024
powersj pushed a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gnmi fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[inputs.gnmi] Got empty metric-name for response
3 participants