Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inputs.gnmi] metrics prefixes are corrupted in 1.29.0 #14889

Closed
egr3s opened this issue Feb 26, 2024 · 3 comments
Closed

[inputs.gnmi] metrics prefixes are corrupted in 1.29.0 #14889

egr3s opened this issue Feb 26, 2024 · 3 comments
Labels
bug unexpected problem or unintended behavior

Comments

@egr3s
Copy link

egr3s commented Feb 26, 2024

Relevant telegraf.conf

[[inputs.gnmi]]
   addresses = [ "ip:port" ]
   username = "user"
   password = "pass"
   encoding = "json"
   redial = "10s"
   enable_tls = false
  [[inputs.gnmi.subscription]]
   name = "port_stats"
   origin = "nokia-state"
   path = "/state/port[port-id=*]/statistics/"
   subscription_mode = "sample"
   sample_interval = "60s"
  [[inputs.gnmi.subscription]]
   name = "flash_free_space"
   origin = "nokia-state"
   path = "/state/cpm[cpm-slot=*]/flash[flash-id=*]/free-space"
   subscription_mode = "sample"
   sample_interval = "60s"

Logs from Telegraf

2024-02-05T18:28:55Z E! [inputs.gnmi] Invalid empty path "/state/port/statistics/out-discards" with alias "nokia-state:/state/port/statistics"
2024-02-05T18:28:55Z E! [inputs.gnmi] Invalid empty path "/state/port/statistics/out-discards" with alias "nokia-state:/state/port/statistics"

System info

telegraf:1.29.0

Docker

No response

Steps to reproduce

  1. configure gNMI input plugin to subscribe to port statistics metrics
  2. redirect output to a file
  3. open the file and see that metrics prefixes are broken

Expected behavior

Metrics shouldn't be corrupted, e.g. with 1.28.5:
path=/state/port/statistics,port_id=A/1,rmrw=allowed,source=ip in_discards="0",in_errors="0",in_octets="52732623",in_packets="573811",in_unknown_protocol_discards="0",in_broadcast_packets="1303",in_multicast_packets="1",in_unicast_packets="572507",out_discards="0",out_errors="0",out_octets="432940948",out_packets="844057",out_broadcast_packets="236",out_multicast_packets="0",out_unicast_packets="843821"

Actual behavior

Metrics names are corrupted
path=/state/port/statistics,port_id=A/1,rmrw=allowed,source=ip in_discards="0",in_errors="0",in_octets="52683510",in_packets="573230",rotocol_discards="0",_packets="1",ackets="571926",out_errors="0",out_octets="432484117",out_packets="842751",t_packets="0",packets="842515"

Additional info

No response

@egr3s egr3s added the bug unexpected problem or unintended behavior label Feb 26, 2024
@egr3s
Copy link
Author

egr3s commented Feb 26, 2024

@ipuustin

@powersj
Copy link
Contributor

powersj commented Feb 26, 2024

telegraf:1.29.0

Could you please update to 1.29.5, there were at least two fixes that went in, the first is probably most interesting to you:

#14553
#14838

@powersj powersj added the waiting for response waiting for response from contributor label Feb 26, 2024
@egr3s
Copy link
Author

egr3s commented Feb 26, 2024

Hi,

1.29.5 seems to solve the issue.

Thanks for quick response.

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Feb 26, 2024
@egr3s egr3s closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants