chore: add out of order tests #25869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
praveen-influx
commented
Jan 20, 2025
praveen-influx
commented
- assertions for what remains in the queryable buffer when out of order timestamps are encountered. This could be true for back filling, and in that case back filled data takes over the queryable buffer and moving all the recent data into parquet files (as part of snapshotting)
- assertions to check last cache still retains the most recent values when out of order data is encountered
praveen-influx
commented
Jan 20, 2025
| @@ -2439,6 +2471,378 @@ mod tests { | |||
| ); | |||
| } | |||
|
|
|||
| #[test_log::test(tokio::test)] | |||
| async fn test_check_mem_and_force_snapshot() { | |||
There was a problem hiding this comment.
This is not a new test, just moved it up so that it's not between test helper functions at the bottom.
- assertions for what remains in the queryable buffer when out of order timestamps are encountered. This could be true for back filling, and in that case back filled data takes over the queryable buffer and moving all the recent data into parquet files (as part of snapshotting) - assertions to check last cache still retains the most recent values when out of order data is encountered
praveen-influx
force-pushed
the
praveen/out-of-order-test
branch
from
83161ef to
e7b4ee6
Compare
hiltontj
approved these changes
Jan 20, 2025
pauldix
approved these changes
Jan 20, 2025
Co-authored-by: Trevor Hilton <[email protected]>
praveen-influx
force-pushed
the
praveen/out-of-order-test
branch
from
1ce7654 to
8e18f02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.