fix: Store.validateArgs wrongfully overwriting start, end unix time #25146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidby-influx
added
kind/bug
area/flux
philjb
approved these changes
Jul 12, 2024
2 tasks
davidby-influx
added a commit
that referenced
this pull request
Jul 15, 2024
…25146) When querying data before 1970-01-01 (UNIX time 0) validateArgs would set start to -in64 max and end to int64 max. closes #24669 Co-authored-by: Paul Hegenberg <[email protected]> (cherry picked from commit c2b3e38) closes #25148
davidby-influx
added a commit
that referenced
this pull request
Jul 15, 2024
…25146) When querying data before 1970-01-01 (UNIX time 0) validateArgs would set start to -in64 max and end to int64 max. closes #24669 Co-authored-by: Paul Hegenberg <[email protected]> closes #25149
davidby-influx
added a commit
that referenced
this pull request
Jul 16, 2024
…25146) (#25165) When querying data before 1970-01-01 (UNIX time 0) validateArgs would set start to -in64 max and end to int64 max. closes #24669 Co-authored-by: Paul Hegenberg <[email protected]> closes #25149
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this pull request
Aug 11, 2024
…nfluxdata#25146) (influxdata#25165) When querying data before 1970-01-01 (UNIX time 0) validateArgs would set start to -in64 max and end to int64 max. closes influxdata#24669 Co-authored-by: Paul Hegenberg <[email protected]> closes influxdata#25149
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this pull request
Aug 27, 2024
…nfluxdata#25146) (influxdata#25165) When querying data before 1970-01-01 (UNIX time 0) validateArgs would set start to -in64 max and end to int64 max. closes influxdata#24669 Co-authored-by: Paul Hegenberg <[email protected]> closes influxdata#25149
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this pull request
Aug 28, 2024
…nfluxdata#25146) (influxdata#25165) When querying data before 1970-01-01 (UNIX time 0) validateArgs would set start to -in64 max and end to int64 max. closes influxdata#24669 Co-authored-by: Paul Hegenberg <[email protected]> closes influxdata#25149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store.ValidateArgs incorrectly bounds time ranges which precede
the Unix epoch time.
Closes #24669