-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Store validateArgs wrongfully overwriting start, end unix time #24741
Conversation
When querying data before 1970-01-01 (UNIX time 0) validateArgs would set start to -in64 max and end to int64 max.
@gwossum - if you have a moment, could you look at this potential bug fix from @paulheg? See the bug report for details. The PR does seem to have targeted the impact code where it is replacing any timestamp less than or equal to I think the code was intending to do this (similar issue for
as This bug seems to be encountered only for queries looking before 1970 so it is rather unlikely to be encountered in the wild, except for @paulheg here! |
…ls.MinNanoTime or higher than models.MaxNanoTime
@philjb with the comment of |
I just added some tests to check this behaviour. |
Is there anything blocking us from merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution!
Cherry-picked to #25146 |
When querying data before 1970-01-01 (UNIX time 0) validateArgs would set start to -in64 max and end to int64 max.
Closes #24669
Changes made:
Removed two faulty if statements.