Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra needed drupal to cms change #62

Closed

Conversation

rowanthorpe
Copy link
Contributor

Relocate view to match controller change which was done in #59, replace inex-specific text with config-values, add "baseurl" value to config to allow use as base for external url (e.g. for cms).

@barryo
Copy link
Member

barryo commented Sep 17, 2013

Hi @rowanthorpe - I'm not going to merge this in as this functionality if very very IXP specific. What I have done instead is made changes (including renaming) to make it clearer what this is all about.

See: 2523924

@barryo barryo closed this Sep 17, 2013
@rowanthorpe
Copy link
Contributor Author

OK, that makes sense. I would just add that I found adding that "urlbase" value to the config has proved very helpful for skinning (I've referenced it several times in doc pages especially), and I suggest that perhaps it is worth adding that to application.ini.dist anyway, irrespective of its use for cms login...? Anyway, personally it just affects whether I edit it or add it when copying from the .dist file - easy enough either way...

barryo added a commit that referenced this pull request Sep 17, 2013
See #62
> I would just add that I found adding that 'urlbase' value to the config has proved very helpful
> for skinning (I've referenced it several times in doc pages especially), and I suggest that
> perhaps it is worth adding that to application.ini.dist anyway, irrespective of its use for cms
> login...?
@barryo
Copy link
Member

barryo commented Sep 17, 2013

Done - see 468198a

Note also that the base URL of the IXP installation is always available in the templates via {genUrl}.

@rowanthorpe rowanthorpe deleted the extra_needed_drupal_to_cms_change branch September 17, 2013 10:46
barryo added a commit that referenced this pull request Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants