Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch RT1060x registers #43

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

Akari202
Copy link
Contributor

I tried to fix #36 and and I added the missing FILT_PRSC that i encountered. I did'nt know if these patches also should apply to the other chips so i only added them to the rt106x chips.

I have never done this kinda thing before so feel free to let me know what i messed up but i think everything should be correct.

Copy link
Member

@mciantyre mciantyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping in. Looks like a good start, and we can build on it with some small patches.

  • I updated Missing register field - FlexSPI - MCR0 - SERCLKDIV #36 to describe all MCUs missing the SERCLKDIV field. There's more than just the 1060, and it would be helpful to fix all affected parts in one go.
  • Based on the reference manuals I have available, the ENC change also affects the 1021.
  • Check in the generated Rust code. Without this, a CI check fails. See the contributing doc to learn about the workflow.

devices/common_patches/flexspi.yaml Outdated Show resolved Hide resolved
@Finomnis
Copy link
Contributor

Finomnis commented Jul 16, 2023

Minor nit: don't check in files without newline termination; most IDEs have an option to correct this automatically.

In VSCode, for example, the relevant settings are:

"files.trimTrailingWhitespace": true,
"files.trimFinalNewlines": true,
"files.insertFinalNewline": true,

@Akari202
Copy link
Contributor Author

The 1011 and 1176 SVDs are not affected. This field is marked as "reserved" in an older 1015 reference manual. Download the latest RM and double check this once NXP's website exits maintenance mode...

Checking the reference manuals this change does effect the 1015. Now that NXP's website is finally back i have checked these registers for all the chips supported by this ral and everything should be properly applied now. I also checked in the generated code so the CI checks should be able to run properly this time

@mciantyre mciantyre changed the base branch from master to add-enc-flexspi-fields August 2, 2023 12:51
Copy link
Member

@mciantyre mciantyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for making these changes throughout all supported chips. I'll release this in the 0.5 series.

@mciantyre mciantyre merged commit 0df785a into imxrt-rs:add-enc-flexspi-fields Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing register field - FlexSPI - MCR0 - SERCLKDIV
3 participants