v2.0.0 #408

benmosher · 2016-07-02T19:39:06Z

#2.0!

First real breaking change! tracking progress here. Most discussion should probably occur on the individual issue pages.

core package (eslint-module-utils)

Pull out src/core into eslint-module-utils, to be published separately for other plugins to leverage.
(copied from #234, closes #233)

bikeshed a better name? (if you're interested in this, open an issue and reference this plzzz)
document (README, etc)
publish as v1
add published version to plugin package dependencies

…lugin-git

…rine dep)

…orts. (#268 and #270)

…(for reuse)

# Conflicts: # .babelrc # CHANGELOG.md # package.json # src/core/getExports.js # src/rules/export.js # src/rules/namespace.js # src/rules/no-duplicates.js # src/rules/no-unresolved.js # tests/src/core/resolve.js # utils/resolve.js

…384)

# Conflicts: # .travis.yml # CHANGELOG.md

coveralls · 2016-07-20T11:13:28Z

Coverage increased (+0.07%) to 97.688% when pulling 3b21478 on v2 into b2184f0 on master.

# Conflicts: # CHANGELOG.md # README.md # package.json # src/core/getExports.js # src/core/ignore.js # src/rules/no-named-as-default-member.js # utils/parse.js

they may have always been broken (aka meaningless) in master

coveralls · 2016-08-23T10:24:41Z

Coverage increased (+0.1%) to 97.832% when pulling 6e3b530 on v2 into 0d98253 on master.

coveralls · 2016-08-23T10:44:21Z

Coverage increased (+0.1%) to 97.838% when pulling d5af34e on v2 into 0d98253 on master.

jfmengels · 2016-08-25T14:22:19Z

We should probably drop support for Node v4 (if it's not already done) and update the rules to the latest format (http://eslint.org/blog/2016/07/eslint-new-rule-format). Willing to do the work, but that should not appear on master before we're close to releasing.

benmosher · 2016-08-26T08:59:21Z

I'm up for the new format, but it wasn't obvious to me that it's urgently necessary, since the older format is still supported and updating the rules should not be a noticeable change for users, right?

Also: isn't ESLint still supporting Node v4?

jfmengels · 2016-08-26T09:48:08Z

Sorry, meant dropping support for Node < v4.

The older format is still supported, and the new format is supported by the latest 2.x versions. I consider it a breaking change, even if I haven't encountered any problems with it. Most plugins I've seen that have made the jump released a major version for it, though they almost all also started using ES2015 features supported by Node v4.

benmosher · 2016-08-26T09:56:27Z

Let's knock it out, then. Feel free to push updated rules to this branch.

And yeah, this branch is v4+. 😎

# Conflicts: # package.json # src/index.js

coveralls · 2016-09-15T10:50:08Z

Coverage increased (+0.1%) to 97.933% when pulling ef1745a on v2 into 2b471c7 on master.

- converted all rules using eslint-transforms tool - updated no-unresolved + namespace to match tool output (module.exports vs. exports.{meta,create})

benmosher · 2016-09-15T11:02:22Z

@jfmengels anything else you can think of that we should address before publishing this?

I'm thinking of publishing as v2.0.0-beta.0?

coveralls · 2016-09-15T11:07:01Z

Coverage increased (+0.09%) to 97.922% when pulling 20079c6 on v2 into 2b471c7 on master.

jfmengels · 2016-09-15T11:09:46Z

Ah, good job for the rule format.
Let's publish a beta v2 yeah (don't forget --tag beta when publishing).

I think we could take a look at updating the recommended config, so that we can at least give a taste of the useful rules that don't need config. I'm thinking no-unresolved, no-extraneous-dependencies, etc. Not opiniated rules, just helpful and probable errors.
But we can do that after the first beta version.

benmosher · 2016-09-23T11:11:33Z

@jfmengels I'll try to merge this over the weekend or early next week.

jfmengels · 2016-09-23T11:30:50Z

Cool! :)

jfmengels · 2016-09-24T20:54:31Z

🎉

benmosher added 13 commits July 2, 2016 14:28

remove es6-* ponyfills

0b77e36

travis: remove Node 0.10

d1dab58

first draft: eslint-module-utils as a separate package

693be17

utils: index.js

59999d6

babel-preset-es2015-argon

9fc02d4

eslint-module-utils/v0.1.0

2c14c4c

pulled out moduleVisitor from no-unresolved, to be used with eslint-p…

96b5ef9

…lugin-git

eslint-module-utils/v0.1.1

206d924

moved ExportMap back into the import plugin from utils (to avoid doct…

2c83aaf

…rine dep)

bumped module utils to 0.2.0

cf38d7a

utils: extracted ModuleCache from resolve cache behavior

25968b8

officially declare node >=4 dependency

8407450

Merge branch 'core-v2' into v2: #234 lives again

32cf1b6

benmosher mentioned this pull request Jul 2, 2016

Core package #234

Closed

9 tasks

missed pkg-dir during rebase of core-package

d5c4c43

benmosher added this to the 2.0.0 milestone Jul 2, 2016

benmosher mentioned this pull request Jul 2, 2016

Expose the resolve function to other plugins #233

Closed

benmosher added 3 commits July 2, 2016 15:59

extra detail about no-duplicates. closes #242

9d6db00

link to import/order (close #259)

12ae0a7

only even try to parse .js imported files by default

633c5ba

benmosher mentioned this pull request Jul 3, 2016

release v1.10.1 #405

Merged

4 tasks

benmosher added 4 commits July 3, 2016 20:17

Merge branch 'master' into v2

fef3929

make linklocal part of the test workflow (for utils, mostly)

1312560

use Unambiguous JavaScript Grammar to detect/ignore non-ES-module imp…

4f1da9a

…orts. (#268 and #270)

added debug log when a file is ignored (#306)

45eab4f

benmosher force-pushed the v2 branch from 7cefeb7 to a55cd67 Compare July 7, 2016 10:50

benmosher added 4 commits July 7, 2016 06:50

recommended shared config (#402)

a55cd67

extracted unambiguous JS grammar patterns/predicates to utils module …

7b25c1c

…(for reuse)

imports-first => first (#424)

8e35cd9

Merge branch 'master' into v2

7791852

# Conflicts: # .babelrc # CHANGELOG.md # package.json # src/core/getExports.js # src/rules/export.js # src/rules/namespace.js # src/rules/no-duplicates.js # src/rules/no-unresolved.js # tests/src/core/resolve.js # utils/resolve.js

benmosher added 4 commits July 12, 2016 21:16

first draft of unambiguous rule to detect ambiguous script/module (#…

e55263f

…384)

Merge branch 'master' into v2

a91e93a

# Conflicts: # .travis.yml # CHANGELOG.md

#384: unambiguous docs + added to recommended config as a warning

9844c62

fixed(?) goof with babel presets that was negatively impacting tests

3b21478

benmosher added 5 commits July 21, 2016 06:34

update UAJSG link

814c511

Merge branch 'master' into v2

d0eaec9

work toward #311, still have a few issues

88c4b94

Merge branch 'master' into v2

3ce2344

# Conflicts: # CHANGELOG.md # README.md # package.json # src/core/getExports.js # src/core/ignore.js # src/rules/no-named-as-default-member.js # utils/parse.js

fixed broken infinite cache tests

6e3b530

they may have always been broken (aka meaningless) in master

added case-insensitivity tests for default/named (#311)

d5af34e

Merge branch 'master' into v2

ef1745a

# Conflicts: # package.json # src/index.js

bump ESLint devDep to 3.x + new rule format

20079c6

- converted all rules using eslint-transforms tool - updated no-unresolved + namespace to match tool output (module.exports vs. exports.{meta,create})

benmosher merged commit 20079c6 into master Sep 24, 2016

jfmengels deleted the v2 branch September 24, 2016 20:54

MaxMood96 mentioned this pull request Jan 10, 2023

[Snyk] Fix for 2 vulnerabilities MaxMood96/eslint-plugin-import#23

Open

MaxMood96 mentioned this pull request Apr 18, 2024

[Snyk] Security upgrade babel-plugin-module-resolver from 2.7.1 to 5.0.1 MaxMood96/eslint-plugin-import#37

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v2.0.0 #408

v2.0.0 #408

benmosher commented Jul 2, 2016 •

edited

Loading

coveralls commented Jul 20, 2016 •

edited

Loading

coveralls commented Aug 23, 2016 •

edited

Loading

coveralls commented Aug 23, 2016 •

edited

Loading

jfmengels commented Aug 25, 2016

benmosher commented Aug 26, 2016

jfmengels commented Aug 26, 2016

benmosher commented Aug 26, 2016

coveralls commented Sep 15, 2016 •

edited

Loading

benmosher commented Sep 15, 2016

coveralls commented Sep 15, 2016 •

edited

Loading

jfmengels commented Sep 15, 2016 •

edited

Loading

benmosher commented Sep 23, 2016

jfmengels commented Sep 23, 2016

jfmengels commented Sep 24, 2016

v2.0.0 #408

v2.0.0 #408

Conversation

benmosher commented Jul 2, 2016 • edited Loading

core package (eslint-module-utils)

coveralls commented Jul 20, 2016 • edited Loading

coveralls commented Aug 23, 2016 • edited Loading

coveralls commented Aug 23, 2016 • edited Loading

jfmengels commented Aug 25, 2016

benmosher commented Aug 26, 2016

jfmengels commented Aug 26, 2016

benmosher commented Aug 26, 2016

coveralls commented Sep 15, 2016 • edited Loading

benmosher commented Sep 15, 2016

coveralls commented Sep 15, 2016 • edited Loading

jfmengels commented Sep 15, 2016 • edited Loading

benmosher commented Sep 23, 2016

jfmengels commented Sep 23, 2016

jfmengels commented Sep 24, 2016

benmosher commented Jul 2, 2016 •

edited

Loading

coveralls commented Jul 20, 2016 •

edited

Loading

coveralls commented Aug 23, 2016 •

edited

Loading

coveralls commented Aug 23, 2016 •

edited

Loading

coveralls commented Sep 15, 2016 •

edited

Loading

coveralls commented Sep 15, 2016 •

edited

Loading

jfmengels commented Sep 15, 2016 •

edited

Loading