Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no-duplicates #242

Closed
lencioni opened this issue Apr 13, 2016 · 2 comments
Closed

Remove no-duplicates #242

lencioni opened this issue Apr 13, 2016 · 2 comments
Milestone

Comments

@lencioni
Copy link
Contributor

This rule appears to be part of ESLint as of 2.5.0. http://eslint.org/docs/rules/no-duplicate-imports

@benmosher
Copy link
Member

Ah, cool, makes sense.

I can't remember if this is in one of the canned configs, but probably ought to replace it with the ESLint rule upon removal.

@benmosher benmosher modified the milestone: next Jul 1, 2016
@benmosher
Copy link
Member

Oh, actually, I think I will keep it. The version of this rule in this plugin resolves the path, so if you use more than one way to get to the same module, it will still be flagged. So it's a bit more powerful than the core version.

It also disambiguates Flow types vs. "normal" imports. Which seems to be desired:

Need to make note of both of these distinguishing features.

preco21 added a commit to preco21/eslint-config-legacy that referenced this issue Jul 7, 2016
preco21 added a commit to preco21/eslint-config-legacy that referenced this issue Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants