Further caching implementation #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Convert extender * Update copyright year
* Fix MVN in MO * Apply feedback and add test * Remove unneeded import * Apply review feedback * Apply review feedback * Fix issue with class name
* Moved input preparation to another function, cleared argparse, minor code improvements * Minor changes in function description
* Comment and type check * test
FileStorageCacheManager - also public Reworked ICacheManager to avoid knowledge of "modelCacheDir" on creation ICacheManager - changed interface to lambdas (TBD: check convinience) Functional tests: created first test with cache enabled - Allow mock_engine.dll to pass import + getMetric - Verifies appropriate Load/Import/Export calls in cached/non-cached modes
nosovmik
changed the title
CacheManagerContext is also removed Support of "CACHE_DIR" global config for model caching Some cleanup of iecore.cpp (not finished) CachingTest - enable CACHE_DIR
Added metric IMPORT_EXPORT_SUPPORT for plugins. Enabled it for Template and Myriad When caching is enabled, Loading by name will not perform 'read network' (hash is calculated by name and device name) Added more CachingTest's - Loading by name - Loading when cache is not supported by plug-in - Loading when cach is not enabled in global config
| auto it = std::find(supportedMetricKeys.begin(), supportedMetricKeys.end(), | ||
| METRIC_KEY(IMPORT_EXPORT_SUPPORT)); | ||
| supported = (it != supportedMetricKeys.end()) && | ||
| plugin.GetMetric(METRIC_KEY(IMPORT_EXPORT_SUPPORT), {}); |
| } | ||
|
|
||
| if (!loadedFromCache) { | ||
| auto cnnNetwork = ReadNetwork(modelPath, ""); |
Verify that mock.0 and mock.1 loads the same cache Verify that mock.50 and mock.51 loads the different cache
| @@ -30,10 +30,12 @@ struct NetworkCompilationContext final { | |||
| const std::map<std::string, std::string> & compileOptions = {}) : | |||
| m_weights{}, | |||
| m_compileOptions{compileOptions}, | |||
| m_modelName{network.getName()}, | |||
There was a problem hiding this comment.
I suppose it's excess in this case, since model name is already in serialized representation after ngraph::pass::Serialize::run_on_function
- Allow user to change cache dir - Allow user to disable caching - Thread-safety of caching enable/disable (no unit tests so far) - FuncTests for Cache_Dir behavior
This reverts commit 7d01f23.
- Support QueryNetwork for "mock" plugin Discovered potential issue with HeteroPlugin (marked as TODO)
- State shall remain previous and shall not be corrupted after exception - Reworked tests to use GMOCK approach
For CNNNetwork it will serialize it and calculate hash on serialized buffer Added tests for corrupted blob and version mismatch
|
Merged to main repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: