Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MVN in MO #4311

Merged
merged 7 commits into from
Feb 20, 2021
Merged

Fix MVN in MO #4311

merged 7 commits into from
Feb 20, 2021

Conversation

mvafin
Copy link
Contributor

@mvafin mvafin commented Feb 12, 2021

Description: Fix issues in MVN transformations in MO

JIRA: 48097

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names

Validation:

  • Unit tests
  • Framework operation tests
  • Transformation tests
  • e2e model test with an update of ./tests/e2e_oss/utils/reshape_utils.py - N/A no new models added
  • Model Optimizer IR Reader check

Documentation:

  • Supported frameworks operations list - N/A
  • Supported public models list - N/A
  • New operations specification - N/A
  • Guide on how to convert the public model - N/A
  • User guide update - N/A

@mvafin mvafin requested a review from a team February 12, 2021 10:37
@mvafin mvafin marked this pull request as draft February 12, 2021 10:37
@openvino-pushbot openvino-pushbot added the category: MO Model Optimizer label Feb 12, 2021
@mvafin mvafin marked this pull request as ready for review February 15, 2021 08:55
@mvafin mvafin requested review from achetver, a team, pavel-esir and iimironov and removed request for a team February 15, 2021 09:00
@mvafin mvafin marked this pull request as draft February 15, 2021 10:51
@achetver
Copy link
Contributor

In general looks good to me.

@mvafin mvafin requested a review from achetver February 15, 2021 20:04
@mvafin mvafin marked this pull request as ready for review February 16, 2021 08:02
@mvafin mvafin requested a review from achetver February 17, 2021 09:15
pavel-esir
pavel-esir approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@pavel-esir pavel-esir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@mvafin mvafin requested a review from lazarevevgeny February 17, 2021 21:18
@mvafin mvafin requested a review from lazarevevgeny February 18, 2021 11:18
@lazarevevgeny lazarevevgeny merged commit bf6b061 into openvinotoolkit:master Feb 20, 2021
@mvafin mvafin deleted the fix/mvn branch February 9, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-esir pavel-esir pavel-esir approved these changes

@iimironov iimironov iimironov approved these changes

@lazarevevgeny lazarevevgeny lazarevevgeny approved these changes

@achetver achetver achetver approved these changes

Assignees

@lazarevevgeny lazarevevgeny

Labels
category: MO Model Optimizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mvafin @achetver @pavel-esir @iimironov @lazarevevgeny @openvino-pushbot