Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up modal discretization group factories #1013

Closed

Conversation

majosm
Copy link
Collaborator

@majosm majosm commented Mar 6, 2024

No longer done automatically in grudge when passing discr_tag_to_group_factory.

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

no longer done automatically in grudge when passing discr_tag_to_group_factory
@majosm majosm force-pushed the set-up-modal-discr-group-factory branch from d33f280 to 8de526a Compare March 6, 2024 22:55
@majosm majosm marked this pull request as ready for review March 7, 2024 00:49
@majosm majosm requested a review from MTCam March 7, 2024 00:50
Copy link
Member

@MTCam MTCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@majosm
Copy link
Collaborator Author

majosm commented Mar 7, 2024

Merged into #1012.

@majosm majosm closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants