Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for meshmode/grudge compatibility #1012

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Fixes for meshmode/grudge compatibility #1012

merged 4 commits into from
Mar 7, 2024

Conversation

majosm
Copy link
Collaborator

@majosm majosm commented Mar 6, 2024

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@majosm majosm marked this pull request as ready for review March 7, 2024 00:49
@majosm majosm requested a review from MTCam March 7, 2024 00:49
MTCam
MTCam approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@MTCam MTCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MTCam
Copy link
Member

MTCam commented Mar 7, 2024

Any chance we could mind-meld this with #1013 before merge just to reduce the amount of CI we need to wait on before making all the updates?

@majosm majosm changed the title Remove use of deprecated discretization group index field Fixes for meshmode/grudge compatibility Mar 7, 2024
@majosm majosm mentioned this pull request Mar 7, 2024
Closed
8 tasks
MTCam
MTCam approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@MTCam MTCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@majosm majosm merged commit 39ba7e7 into illinois-ceesd:main Mar 7, 2024
12 of 13 checks passed
tulioricci pushed a commit that referenced this pull request Mar 11, 2024
@majosm @tulioricci
Fixes for meshmode/grudge compatibility (#1012)
5131b60 
* remove use of deprecated discretization group index field

* found some more

* set up modal discretization group factories

no longer done automatically in grudge when passing discr_tag_to_group_factory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MTCam MTCam MTCam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@majosm @MTCam