Handle Python 3.9 _SpecialGenericAlias #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See https://github.com/bnavigator/typing_inspect/runs/2159879881 for a sucessful Travis CI run on Python 3.9 when #68 and #69 are combined. |
This was referenced Mar 21, 2021
Closed
Closed
bnavigator
commented
Mar 21, 2021
typing_inspect.py
Outdated
Comment on lines
463
to
464
| if isinstance(tp, typingGenericAlias): | ||
| res = tp.__args__ |
There was a problem hiding this comment.
From libcst test suite:
[ 133s] ERROR: test_basic_pass_19 (libcst.tests.test_type_enforce.TypeEnforcementTest)
[ 133s] ----------------------------------------------------------------------
[ 133s] Traceback (most recent call last):
[ 133s] File "/home/abuild/rpmbuild/BUILD/libcst-0.3.16/libcst/testing/utils.py", line 90, in new_test
[ 133s] return member(self, *data)
[ 133s] File "/home/abuild/rpmbuild/BUILD/libcst-0.3.16/libcst/tests/test_type_enforce.py", line 141, in test_basic_pass
[ 133s] is_value_of_type(value, expected_type),
[ 133s] File "/home/abuild/rpmbuild/BUILD/libcst-0.3.16/libcst/_type_enforce.py", line 146, in is_value_of_type
[ 133s] type_args = get_args(expected_type, evaluate=True)
[ 133s] File "/usr/lib/python3.9/site-packages/typing_inspect.py", line 436, in get_args
[ 133s] res = tp.__args__
[ 133s] File "/usr/lib64/python3.9/typing.py", line 694, in __getattr__
[ 133s] raise AttributeError(attr)
[ 133s] AttributeError: __args__
ilevkivskyi
approved these changes
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another take at #66 which keeps compatibility with older Python versions.
Fixes #60