Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import typing._TypedDictMeta in Python 3.9 #68

Merged
merged 1 commit into from
Mar 21, 2021
Merged

import typing._TypedDictMeta in Python 3.9 #68

merged 1 commit into from
Mar 21, 2021

Conversation

bnavigator
Copy link
Contributor

@bnavigator bnavigator commented Mar 21, 2021 •
edited by ilevkivskyi
Loading

typing_extensions just re-exports typing in Python3.9. type(typing.TypedDict) is just a function in Python3.9, just as in typing_extensions.

Fixes #65

@bnavigator bnavigator mentioned this pull request Mar 21, 2021
Merged
@bnavigator
Copy link
Contributor Author

See https://github.com/bnavigator/typing_inspect/runs/2159879881 for a sucessful Travis CI run on Python 3.9 when #68 and #69 are combined.

This was referenced Mar 21, 2021
Closed
Closed
@ilevkivskyi
Copy link
Owner

Thanks! The referenced issue number looks wrong. I think it should be #65, going to edit before merging.

@ilevkivskyi ilevkivskyi merged commit 6dd6b38 into ilevkivskyi:master Mar 21, 2021
@bnavigator
Copy link
Contributor Author

Nope I was aware that #65 is not fully complete by this and #69. But you are right, #64 was fixed by #69, not this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Python 3.9
2 participants
@bnavigator @ilevkivskyi