Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #118, #119, #120, #121, #122, #123, #129 for
Q6_K
.If nothing else
Q6_K
is routinely used for the output tensor, so having a betterQ6_K
performance would be useful.We get a large speedup on
ARM_NEON
and non-negligible gains onAVX2/Zen4
. Here isPP-512
for LLaMA-3.1-8B onZen4
(Ryzen-7950X),ARM_NEON
(M2-Max) andAVX2
(Ryzen-5975WX)Except on
ARM_NEON
, where TG performance is slightly lower for small numbers of threads, we gain even for TG. Here results for TG-128 on LLaMA-3.1-8B with different numbers of threads:With this Zen4 implementation, for TG the available memory bandwidth is fully saturated with just 2 threads!