Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cmd cleanup #3095

Merged
merged 7 commits into from
Nov 14, 2022
Merged

refactor: cmd cleanup #3095

merged 7 commits into from
Nov 14, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Nov 10, 2022

Closes #3080.

The --yes flag in question actually has a purpose in the command. I wasn't able to actually find any unnecessary flags.

Just cleaned up some of the cmd package.

@jeronimoalbi the help texts look fine to me. Let me know if you see issues I'm missing.

@aljo242 aljo242 changed the title refactor: cmd flags refactor: cmd cleanup Nov 10, 2022
@aljo242 aljo242 added the skip-changelog Don't check changelog for new entries label Nov 10, 2022
@aljo242 aljo242 requested a review from jeronimoalbi November 11, 2022 17:53
@lumtis lumtis linked an issue Nov 11, 2022 that may be closed by this pull request
services/cmd: cleanup unused flagsets #3089
Closed
lumtis
lumtis previously approved these changes Nov 11, 2022
View reviewed changes
tbruyelle
tbruyelle previously approved these changes Nov 13, 2022
View reviewed changes
@aljo242 aljo242 dismissed stale reviews from tbruyelle and lumtis via 5c1895c November 14, 2022 14:07
@aljo242 aljo242 merged commit a572663 into develop Nov 14, 2022
@aljo242 aljo242 deleted the refactor/cmd-flags branch November 14, 2022 14:38
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
refactor: cmd cleanup (ignite#3095)
5378ede 
* cleanup

* session

* format

* revert session in cmd-account

* make format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbruyelle tbruyelle tbruyelle left review comments

@lumtis lumtis lumtis left review comments

@ilgooz ilgooz Awaiting requested review from ilgooz

@fadeev fadeev Awaiting requested review from fadeev

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

Assignees
No one assigned
Labels
skip-changelog Don't check changelog for new entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

services/cmd: cleanup unused flagsets interactive cli don't work for chain init
4 participants
@aljo242 @tbruyelle @jeronimoalbi @lumtis