refactor: cmd cleanup (#3095)

* cleanup * session * format * revert session in cmd-account * make format
ignite · Nov 14, 2022 · a572663 · a572663
1 parent e776c40
commit a572663
Show file tree

Hide file tree

Showing 15 changed files with 16 additions and 19 deletions.
diff --git a/ignite/cmd/account_list.go b/ignite/cmd/account_list.go
@@ -18,7 +18,7 @@ func NewAccountList() *cobra.Command {
 	return c
 }
 
-func accountListHandler(cmd *cobra.Command, args []string) error {
+func accountListHandler(cmd *cobra.Command, _ []string) error {
 	ca, err := cosmosaccount.New(
 		cosmosaccount.WithKeyringBackend(getKeyringBackend(cmd)),
 		cosmosaccount.WithHome(getKeyringDir(cmd)),

diff --git a/ignite/cmd/chain_build.go b/ignite/cmd/chain_build.go
@@ -105,7 +105,6 @@ func chainBuildHandler(cmd *cobra.Command, _ []string) error {
 			cliui.StartSpinner(),
 		)
 	)
-
 	defer session.End()
 
 	chainOption := []chain.Option{

diff --git a/ignite/cmd/chain_faucet.go b/ignite/cmd/chain_faucet.go
@@ -34,7 +34,6 @@ func chainFaucetHandler(cmd *cobra.Command, args []string) error {
 			cliui.StartSpinner(),
 		)
 	)
-
 	defer session.End()
 
 	chainOption := []chain.Option{

diff --git a/ignite/cmd/chain_init.go b/ignite/cmd/chain_init.go
@@ -92,7 +92,6 @@ func chainInitHandler(cmd *cobra.Command, _ []string) error {
 		cliui.WithVerbosity(getVerbosity(cmd)),
 		cliui.StartSpinner(),
 	)
-
 	defer session.End()
 
 	chainOption := []chain.Option{

diff --git a/ignite/cmd/docs.go b/ignite/cmd/docs.go
@@ -18,7 +18,7 @@ func NewDocs() *cobra.Command {
 	return c
 }
 
-func docsHandler(cmd *cobra.Command, args []string) error {
+func docsHandler(*cobra.Command, []string) error {
 	path, cleanup, err := localfs.SaveTemp(docs.Docs)
 	if err != nil {
 		return err

diff --git a/ignite/cmd/generate_composables.go b/ignite/cmd/generate_composables.go
@@ -22,7 +22,7 @@ func NewGenerateComposables() *cobra.Command {
 	return c
 }
 
-func generateComposablesHandler(cmd *cobra.Command, args []string) error {
+func generateComposablesHandler(cmd *cobra.Command, _ []string) error {
 	session := cliui.New(cliui.StartSpinnerWithText(statusGenerating))
 	defer session.End()
 

diff --git a/ignite/cmd/generate_go.go b/ignite/cmd/generate_go.go
@@ -21,7 +21,7 @@ func NewGenerateGo() *cobra.Command {
 	return c
 }
 
-func generateGoHandler(cmd *cobra.Command, args []string) error {
+func generateGoHandler(cmd *cobra.Command, _ []string) error {
 	session := cliui.New(cliui.StartSpinnerWithText(statusGenerating))
 	defer session.End()
 

diff --git a/ignite/cmd/generate_hooks.go b/ignite/cmd/generate_hooks.go
@@ -22,7 +22,7 @@ func NewGenerateHooks() *cobra.Command {
 	return c
 }
 
-func generateHooksHandler(cmd *cobra.Command, args []string) error {
+func generateHooksHandler(cmd *cobra.Command, _ []string) error {
 	session := cliui.New(cliui.StartSpinnerWithText(statusGenerating))
 	defer session.End()
 

diff --git a/ignite/cmd/generate_openapi.go b/ignite/cmd/generate_openapi.go
@@ -21,7 +21,7 @@ func NewGenerateOpenAPI() *cobra.Command {
 	return c
 }
 
-func generateOpenAPIHandler(cmd *cobra.Command, args []string) error {
+func generateOpenAPIHandler(cmd *cobra.Command, _ []string) error {
 	session := cliui.New(cliui.StartSpinnerWithText(statusGenerating))
 	defer session.End()
 

diff --git a/ignite/cmd/generate_typescript_client.go b/ignite/cmd/generate_typescript_client.go
@@ -22,7 +22,7 @@ func NewGenerateTSClient() *cobra.Command {
 	return c
 }
 
-func generateTSClientHandler(cmd *cobra.Command, args []string) error {
+func generateTSClientHandler(cmd *cobra.Command, _ []string) error {
 	session := cliui.New(cliui.StartSpinnerWithText(statusGenerating))
 	defer session.End()
 

diff --git a/ignite/cmd/generate_vuex.go b/ignite/cmd/generate_vuex.go
@@ -22,7 +22,7 @@ func NewGenerateVuex() *cobra.Command {
 	return c
 }
 
-func generateVuexHandler(cmd *cobra.Command, args []string) error {
+func generateVuexHandler(cmd *cobra.Command, _ []string) error {
 	session := cliui.New(cliui.StartSpinnerWithText(statusGenerating))
 	defer session.End()
 

diff --git a/ignite/cmd/network_campaign_publish.go b/ignite/cmd/network_campaign_publish.go
@@ -20,7 +20,7 @@ func NewNetworkCampaignPublish() *cobra.Command {
 		Args:  cobra.ExactArgs(2),
 		RunE:  networkCampaignPublishHandler,
 	}
-	c.Flags().String(flagMetadata, "", "Add a metada to the chain")
+	c.Flags().String(flagMetadata, "", "Add a metadata to the chain")
 	c.Flags().AddFlagSet(flagNetworkFrom())
 	c.Flags().AddFlagSet(flagSetKeyringBackend())
 	c.Flags().AddFlagSet(flagSetKeyringDir())

diff --git a/ignite/cmd/node_query_bank_balances.go b/ignite/cmd/node_query_bank_balances.go
@@ -24,6 +24,9 @@ func NewNodeQueryBankBalances() *cobra.Command {
 }
 
 func nodeQueryBankBalancesHandler(cmd *cobra.Command, args []string) error {
+	session := cliui.New(cliui.StartSpinnerWithText(statusQuerying))
+	defer session.End()
+
 	inputAccount := args[0]
 
 	client, err := newNodeCosmosClient(cmd)
@@ -42,9 +45,6 @@ func nodeQueryBankBalancesHandler(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	session := cliui.New(cliui.StartSpinnerWithText(statusQuerying))
-	defer session.End()
-
 	balances, err := client.BankBalances(cmd.Context(), address, pagination)
 	if err != nil {
 		return err

diff --git a/ignite/cmd/node_tx_bank_send.go b/ignite/cmd/node_tx_bank_send.go
@@ -19,6 +19,9 @@ func NewNodeTxBankSend() *cobra.Command {
 }
 
 func nodeTxBankSendHandler(cmd *cobra.Command, args []string) error {
+	session := cliui.New()
+	defer session.End()
+
 	var (
 		fromAccountInput = args[0]
 		toAccountInput   = args[1]
@@ -53,9 +56,6 @@ func nodeTxBankSendHandler(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	session := cliui.New()
-	defer session.End()
-
 	if generateOnly {
 		json, err := tx.EncodeJSON()
 		if err != nil {

diff --git a/ignite/cmd/scaffold_react.go b/ignite/cmd/scaffold_react.go
@@ -8,7 +8,7 @@ import (
 	"github.com/ignite/cli/ignite/pkg/cosmosgen"
 )
 
-// NewScaffoldReacr scaffolds a React app for a chain.
+// NewScaffoldReact scaffolds a React app for a chain.
 func NewScaffoldReact() *cobra.Command {
 	c := &cobra.Command{
 		Use:     "react",
-Original file line number
+Diff line change
@@ Expand Up @@
     			cliui.StartSpinner(),
     		)
     	)
     	defer session.End()
     	chainOption := []chain.Option{
@@ Expand Down @@