Fix testing #1075
Merged
Fix testing #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There has been a deprecation on one of the github action modules storing artifacts when tests fail. That leads all tests to be failing before updating to a newer version which happens in this PR.
|
seems like the fix is actually working and tests pass again, so ready to merge whenever someone approves (note that other PRs will need to have merged master into them after, such that tests do not trivially fail there). |
iprafols
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a deprecation on one of the github action modules storing artifacts when tests fail. That leads all tests to be failing before updating to a newer version which happens in this PR.