-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bump minor] add IVAR to all forest outputs #1074
Conversation
all tests but script tests are passing now (at least locally on my machine), so updating the offending test files (delta files for BAO need to have the IVAR in the tests), once those are fixed things should be ready to go. |
Tests should be fine after merging #1075. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things look good, I'd say to merge this
The PR looks fine ! In any case I think this is a good thing to always add IVAR, I use it also for the Lya tomography. |
bumping at least the minor version as the data format changes, even if only additions happen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too.
Adding the IVAR to outputs. Tests aren't fixed yet.