Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate and enhance SimScheduler tests #286

Merged
merged 9 commits into from
Aug 2, 2022

Conversation

sebastian-peter
Copy link
Member

@sebastian-peter sebastian-peter commented Jul 14, 2022

Resolves #285

This adaption of SimScheduler tests is largely based on my master's thesis at ie³.

Merge this before #284

@sebastian-peter sebastian-peter added the test Issues related to (unit) tests label Jul 14, 2022
@sebastian-peter sebastian-peter self-assigned this Jul 14, 2022
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #286 (63f8621) into dev (696e571) will increase coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #286      +/-   ##
==========================================
+ Coverage   79.50%   79.83%   +0.33%     
==========================================
  Files         159      159              
  Lines        5835     5838       +3     
  Branches       80       80              
==========================================
+ Hits         4639     4661      +22     
+ Misses       1196     1177      -19     
Impacted Files Coverage Δ
...cala/edu/ie3/simona/agent/grid/DBFSAlgorithm.scala 83.81% <0.00%> (+0.97%) ⬆️
...ala/edu/ie3/simona/scheduler/SchedulerHelper.scala 93.90% <0.00%> (+1.52%) ⬆️
.../scala/edu/ie3/simona/scheduler/SimScheduler.scala 96.61% <0.00%> (+23.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 696e571...63f8621. Read the comment docs.

Enhancing test with exceptional cases
@sonarqubegithubprchecks

This comment has been minimized.

@sebastian-peter sebastian-peter marked this pull request as ready for review July 17, 2022 18:25
@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

1 Issue

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell1 Code Smell

Coverage and Duplications

  • 100 percent coverage100.00% Coverage (82.10% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

@t-ober t-ober self-assigned this Aug 1, 2022
Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very n🍦. Just two little things

@sebastian-peter sebastian-peter requested a review from t-ober August 1, 2022 19:14
@t-ober t-ober merged commit e7c9884 into dev Aug 2, 2022
@t-ober t-ober deleted the sp/#285-SimSchedulerSpec-enhancement branch August 2, 2022 06:59
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues related to (unit) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance and consolidate tests for SimScheduler
2 participants