Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing faster data structures to SimScheduler #284

Merged
merged 27 commits into from
Sep 16, 2022

Conversation

sebastian-peter
Copy link
Member

@sebastian-peter sebastian-peter commented Jul 12, 2022

Resolves #282

Idea and implementation taken from my master's thesis at ie³.

Merge #286 first!

@sebastian-peter sebastian-peter added the speed Improves execution speed, leading to shorter runtimes label Jul 12, 2022
@sebastian-peter sebastian-peter self-assigned this Jul 12, 2022
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Base: 80.27% // Head: 80.30% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (f8adc66) compared to base (b83c777).
Patch has no changes to coverable lines.

❗ Current head f8adc66 differs from pull request most recent head ee2cf96. Consider uploading reports for the commit ee2cf96 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #284      +/-   ##
==========================================
+ Coverage   80.27%   80.30%   +0.02%     
==========================================
  Files         161      162       +1     
  Lines        5917     5924       +7     
  Branches       81       79       -2     
==========================================
+ Hits         4750     4757       +7     
  Misses       1167     1167              
Impacted Files Coverage Δ
...ala/edu/ie3/simona/scheduler/SchedulerHelper.scala 92.77% <0.00%> (-1.14%) ⬇️
...cala/edu/ie3/simona/agent/grid/DBFSAlgorithm.scala 83.47% <0.00%> (-0.85%) ⬇️
...ie3/simona/ontology/trigger/ScheduledTrigger.scala
...e3/util/scala/collection/mutable/CountingMap.scala 100.00% <0.00%> (ø)
.../scala/collection/mutable/PriorityMultiQueue.scala 95.45% <0.00%> (ø)
...e3/simona/agent/participant/ParticipantAgent.scala 82.95% <0.00%> (+4.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubegithubprchecks

This comment has been minimized.

1 similar comment
@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

1 Issue

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell1 Code Smell

Coverage and Duplications

  • 90 percent coverage95.12% Coverage (82.10% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

@sebastian-peter sebastian-peter marked this pull request as ready for review August 2, 2022 20:53
Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! Something about the data classes being very concise and orderly is pretty satisfying.

Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N🍨 work !!

@sebastian-peter sebastian-peter merged commit 67a79db into dev Sep 16, 2022
@sebastian-peter sebastian-peter deleted the sp/#282-SimScheduler-data-structures branch September 16, 2022 13:54
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
speed Improves execution speed, leading to shorter runtimes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved data structures for SimScheduler
2 participants