Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed pvInput values and corresponding expected results #1177

Merged
merged 13 commits into from
Feb 17, 2025
Merged

changed pvInput values and corresponding expected results #1177

merged 13 commits into from
Feb 17, 2025

Conversation

marvinheintze
Copy link
Contributor

Resolves #1144

Changed the pvInput values und the corresponding equalWithTolerance values in EmAgentIT

@marvinheintze marvinheintze self-assigned this Feb 13, 2025
sebastian-peter
sebastian-peter reviewed Feb 13, 2025
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll have @danielfeismann have the final say

danielfeismann
danielfeismann requested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this issue! I found some artefacts which I'll fix directly (scaling of PV).

@danielfeismann danielfeismann added the code quality Code readability or efficiency is improved label Feb 13, 2025
@danielfeismann danielfeismann mentioned this pull request Feb 16, 2025
Draft
danielfeismann
danielfeismann requested changes Feb 17, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for considering my inputs so far. A few more little things, but almost through :)

danielfeismann
danielfeismann approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, found one little last thing and fixed it directly. Thanks for improving our test cases!

@danielfeismann danielfeismann merged commit 4ea6c77 into dev Feb 17, 2025
4 checks passed
@danielfeismann danielfeismann deleted the mh/#1144-realistic-PvInputTestData-values branch February 17, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter left review comments

@danielfeismann danielfeismann danielfeismann approved these changes

Assignees

@marvinheintze marvinheintze

Labels
code quality Code readability or efficiency is improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor pvInput in PvInputTestData to realistic values
3 participants
@marvinheintze @sebastian-peter @danielfeismann