Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pvInput in PvInputTestData to realistic values #1144

Closed
danielfeismann opened this issue Feb 6, 2025 · 0 comments · Fixed by #1177
Closed

Refactor pvInput in PvInputTestData to realistic values #1144

danielfeismann opened this issue Feb 6, 2025 · 0 comments · Fixed by #1177
Assignees
@marvinheintze
Labels
test Issues related to (unit) tests

Comments

@danielfeismann
Copy link
Member

The current implementation of pvInput in PvInputTestData uses some unrealistic values. Perhaps we can fix this and refactor the tests that would then fail.

At first glance these are

albedo = 1 => 0.2
etaConv = 10% (Quantities.getQuantity(10, StandardUnits.EFFICIENCY)) => ~ 90%
elevation_angle = 100 (Quantities.getQuantity(100, StandardUnits.SOLAR_ELEVATION_ANGLE)) => 45°
kg = 12 => 0.9
kT =11 => 1.0
@danielfeismann danielfeismann added the test Issues related to (unit) tests label Feb 6, 2025
@marvinheintze marvinheintze self-assigned this Feb 11, 2025
@marvinheintze marvinheintze mentioned this issue Feb 13, 2025
Merged
marvinheintze added a commit that referenced this issue Feb 17, 2025
@marvinheintze
Merge branch 'dev' into mh/#1144-realistic-PvInputTestData-values
a058c06 
# Conflicts:
#	CHANGELOG.md
danielfeismann added a commit that referenced this issue Feb 17, 2025
@danielfeismann
Merge branch 'dev' into mh/#1144-realistic-PvInputTestData-values
2b08744
danielfeismann added a commit that referenced this issue Feb 17, 2025
@danielfeismann
Merge pull request #1177 from ie3-institute/mh/#1144-realistic-PvInpu…
4ea6c77 
…tTestData-values

changed pvInput values and corresponding expected results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinheintze marvinheintze

Labels
test Issues related to (unit) tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changed pvInput values and corresponding expected results ie3-institute/simona
2 participants
@danielfeismann @marvinheintze