Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3.0.0 #342

Draft
wants to merge 121 commits into
base: master
Choose a base branch
from
Draft

V3.0.0 #342

wants to merge 121 commits into from

Conversation

daveroga
Copy link
Contributor

@daveroga daveroga commented Feb 4, 2025 •
edited
Loading

  • Includes multi-query support on-chain
  • Track changes from auditors
  • Track changes from master fixes

daveroga and others added 30 commits November 26, 2024 11:18
@daveroga
new universal verifier multi-query
bf71699
@AndriianChestnykh
Discussion results
74b24a1
@AndriianChestnykh
Discussion results 2
16a8b27
@daveroga
update universal verifier multi query
f05104d
@daveroga
remove ZKP
779513f
@daveroga
add auth validators
8da12c7
@AndriianChestnykh
Broader discussion results
ba75a5d
@AndriianChestnykh
Add agreed universal verifier solution
ae9cec1
@daveroga
update universal verifier multi query with agreed design
790a0e3
@daveroga
query status and submit response
1858dce
@daveroga
get request type from 30 byte of the requestId
4527834
@daveroga
add EthIdentityValidator
bb82ff3
@daveroga
updates from review
e66a160
@AndriianChestnykh
Discussion result
d416b9a
@daveroga
updates from discussion
a26861c
@daveroga
check response field values from linked response fields
0c2e792
@daveroga
fix some errors in compilation
16f8b5a
@daveroga
test universal verifier multi-query
4afb814
@daveroga
different validators for sig and authv2
8f55467
@daveroga
check specific storage values
657fa6c
@daveroga
overrides solidity compiler optimizations for specific contract
46d17ab
@daveroga
remove some methods
1e7b877
@daveroga
fix solhint
2942cdf
@daveroga
update from discussion
a91c1e7
@daveroga
set group of requests and check linkID
849e790
@daveroga
fix solhint
a02592c
@daveroga
updates from review
6b82ff0
@daveroga
fix cyclomatic-complexity
d35e4b4
@daveroga
some fixes from review
3811b9c
@daveroga
updates from tech spec
4030067
daveroga and others added 21 commits January 28, 2025 10:48
@daveroga
resolve solhint warnings
19da90c
@daveroga
update from review comments
f238b05
@daveroga
update AuthV2Validator
127c40c
@daveroga
add function getResponseFields to verifier
374ea04
@AndriianChestnykh
Remove unused tests and comments
f553fed
@daveroga
updates from review
67bc7fe
@daveroga
update requestId calculation
a817f35
@daveroga
fix solhint
569c6b6
@daveroga
update RequestStatus for RequestProofStatus
5025be6
@daveroga
more updates from review
de9d7a5
@daveroga
more updates from review
50960a8
@daveroga
change AuthType to AuthMethod
6334aa3
@daveroga
precalculate keccack256 of field names
707a770
@AndriianChestnykh
Merge remote-tracking branch 'refs/remotes/origin/master' into PID-27…
7a5f833 
…09-full-multi-query-support-on-chain

# Conflicts:
#	scripts/deploy/deployState.ts
#	scripts/deploy/deployValidators.ts
#	scripts/maintenance/checkEmbeddedZKPVerifier.ts
#	scripts/upgrade/verifiers/embedded-verifier-upgrade.ts
@daveroga
solve solhint warning explicit type
d46b262
@daveroga
fix solhint warnings
ccd69f9
@daveroga
fix solhint warnings for custom errors
0473eca
@daveroga
fix circuitId for linkedMultiQuery10-beta.1
a52ebd1
@daveroga
comment requestId calculation
598272a
@daveroga
v3.0.0
a09e038
@daveroga
Merge pull request #321 from iden3/PID-2709-full-multi-query-support-…
92f00c0 
…on-chain

Full Multi-query support onchain
@coveralls
Copy link

coveralls commented Feb 4, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13549676037

Details

  • 543 of 616 (88.15%) changed or added relevant lines in 31 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.0%) to 86.063%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/lib/ClaimBuilder.sol 13 14 92.86%
contracts/lib/PrimitiveTypeUtils.sol 3 4 75.0%
contracts/lib/groth16-verifiers/Groth16VerifierAuthV2Wrapper.sol 2 3 66.67%
contracts/lib/groth16-verifiers/Groth16VerifierLinkedMultiQuery10Wrapper.sol 5 6 83.33%
contracts/lib/groth16-verifiers/Groth16VerifierMTPWrapper.sol 2 3 66.67%
contracts/lib/groth16-verifiers/Groth16VerifierSigWrapper.sol 2 3 66.67%
contracts/lib/groth16-verifiers/Groth16VerifierV3Wrapper.sol 2 3 66.67%
contracts/lib/IdentityBase.sol 0 2 0.0%
contracts/validators/request/LinkedMultiQueryValidator.sol 58 60 96.67%
contracts/verifiers/ValidatorWhitelist.sol 6 8 75.0%
Files with Coverage Reduction New Missed Lines %
contracts/lib/IdentityBase.sol 1 61.11%
contracts/state/State.sol 4 75.13%
Totals Coverage Status
Change from base Build 13413531959: 1.0%
Covered Lines: 1324
Relevant Lines: 1449
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriianChestnykh AndriianChestnykh Awaiting requested review from AndriianChestnykh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daveroga @coveralls @AndriianChestnykh