-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full Multi-query support onchain #321
Conversation
b70f050
to
a02592c
Compare
keccak256(abi.encodePacked("challenge")) | ||
) { | ||
bytes32 expectedNonce = keccak256(abi.encode(sender, responses)) & | ||
0x0FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be 0x00FFFF... if we want to zero out the first byte.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only with the first position as 0 that is 4 bits we have 252 bits remaining for the calculation that fits in a field number. But I could do it with 1 byte if you think it's better an we we'll use 248 bits then.
df615af
to
707a770
Compare
…09-full-multi-query-support-on-chain # Conflicts: # scripts/deploy/deployState.ts # scripts/deploy/deployValidators.ts # scripts/maintenance/checkEmbeddedZKPVerifier.ts # scripts/upgrade/verifiers/embedded-verifier-upgrade.ts
af11142
to
af48dff
Compare
af48dff
to
0473eca
Compare
05b54b3
to
8650ac6
Compare
8650ac6
to
598272a
Compare
Implement multi-request support similar to existing requests now in Universal Verifier.
MultiRequest
) independently and in the same way we are managing Requests in ZKPVerifierBase now (setMultiRequest, getMultiRequest, …). Avoid ZKP and generalize methods in Requests. setRequest, getRequest, submitResponse, …linkID
between the Requests and Auth of the sameQuery
.uint64
touint256
.Link to Tech Spec for changes: https://www.notion.so/privado-id/Multi-query-Tech-Spec-13d4f86a875180e68fc8e3fa5362805e