Code

Port trivia line by line C# -> VB#512

Code

Merged

GrahamTheCoder merged 66 commits intomastericsharpcode/CodeConverter:masterfrom rewrite-method-triviaicsharpcode/CodeConverter:rewrite-method-triviaCopy head branch name to clipboardFeb 3, 2020

+1,092-355

Commits

Commits on Jan 28, 2020

• Easy fixups

  GrahamTheCoder

  committed
  db2b431

  Copy full SHA for db2b431

• Improve todo messages

  Show description for c6a4391
  GrahamTheCoder

  committed
  c6a4391

  Copy full SHA for c6a4391

• Be explicit about language

  GrahamTheCoder

  committed
  01123d3

  Copy full SHA for 01123d3

• Allow regions

  GrahamTheCoder

  committed
  4f46104

  Copy full SHA for 4f46104

• Map line-by-line trivia where expressions are close by

  GrahamTheCoder

  committed
  e12ff8e

  Copy full SHA for e12ff8e

• Implement rudimentary trivia conversions

  GrahamTheCoder

  committed
  b9d26c0

  Copy full SHA for b9d26c0

• Recharacterize - not sure why assembly attributes have gained newline

  GrahamTheCoder

  committed
  e725937

  Copy full SHA for e725937

• Remove extra newlines in tests

  GrahamTheCoder

  committed
  e9b3b88

  Copy full SHA for e9b3b88

• Add mapping for identifiers (so the start of blocks works better)

  GrahamTheCoder

  committed
  8e5c460

  Copy full SHA for 8e5c460

Commits on Jan 29, 2020

• Split class, separate leading/trailing and annotate more nodes

  GrahamTheCoder

  committed
  bbe0089

  Copy full SHA for bbe0089

• Test comments automatically

  GrahamTheCoder

  committed
  5129242

  Copy full SHA for 5129242

• Add information useful for debug that could be used to split phase

  GrahamTheCoder

  committed
  8fe5a03

  Copy full SHA for 8fe5a03

• Remove guessing phase

  Show description for de03b54
  GrahamTheCoder

  committed
  de03b54

  Copy full SHA for de03b54

• Off topic: This test wasn't inverted after being copied

  GrahamTheCoder

  committed
  31671dd

  Copy full SHA for 31671dd

• Test that passes but characterizes some remaining issues

  GrahamTheCoder

  committed
  f7d0efc

  Copy full SHA for f7d0efc

• Fix missing quotes for region name

  GrahamTheCoder

  committed
  a8372c9

  Copy full SHA for a8372c9

• Fix compilation of test case

  Show description for 2f6e380
  GrahamTheCoder

  committed
  2f6e380

  Copy full SHA for 2f6e380

• Avoid duplication and increase happy path performance

  GrahamTheCoder

  committed
  cf7f0af

  Copy full SHA for cf7f0af

• Improve errors messages for comment bugs

  GrahamTheCoder

  committed
  ef1f5e7

  Copy full SHA for ef1f5e7

• Remove unused

  GrahamTheCoder

  committed
  2e7f1d0

  Copy full SHA for 2e7f1d0

Commits on Jan 30, 2020

• Deal with some zero width tokens like EOF

  GrahamTheCoder

  committed
  11138c4

  Copy full SHA for 11138c4

• Start trying to deal with block starts

  GrahamTheCoder

  committed
  c91bf71

  Copy full SHA for c91bf71

• Improve assertions

  GrahamTheCoder

  committed
  2b4219f

  Copy full SHA for 2b4219f

Commits on Jan 31, 2020

• Cater for block starts with carry over and recharacterize (31 fail)

  GrahamTheCoder

  committed
  f94e7d9

  Copy full SHA for f94e7d9

• Comment simplified line

  GrahamTheCoder

  committed
  cb7a97f

  Copy full SHA for cb7a97f

• Zero index for easier debugging of the mapper

  GrahamTheCoder

  committed
  ab16d70

  Copy full SHA for ab16d70

• Add indirection similar to what's used in VB-> C#

  GrahamTheCoder

  committed
  4d184e9

  Copy full SHA for 4d184e9

• Don't map trivia for these nodes

  GrahamTheCoder

  committed
  62cec21

  Copy full SHA for 62cec21

• Cover descendants too for future sanity (23 tests fail)

  GrahamTheCoder

  committed
  6f00fb1

  Copy full SHA for 6f00fb1

• Comment intentionally moved using statement (22 tests fail)

  GrahamTheCoder

  committed
  430507e

  Copy full SHA for 430507e

Commits on Feb 1, 2020

• Manually map block ends where they might end a file

  GrahamTheCoder

  committed
  c3f7396

  Copy full SHA for c3f7396

• Never find zero width tokens (24 tests fail)

  GrahamTheCoder

  committed
  47f9faf

  Copy full SHA for 47f9faf

• Use elastic crlf but don't normalize - recharectirize

  GrahamTheCoder

  committed
  99dc501

  Copy full SHA for 99dc501

• Change order

  GrahamTheCoder

  committed
  2dba16f

  Copy full SHA for 2dba16f

• Use collections

  GrahamTheCoder

  committed
  d1ba056

  Copy full SHA for d1ba056

• Deal with using directives better

  GrahamTheCoder

  committed
  9e0ebc8

  Copy full SHA for 9e0ebc8

Commits on Feb 2, 2020

• renames

  GrahamTheCoder

  committed
  ec8799a

  Copy full SHA for ec8799a

• Add new members

  GrahamTheCoder

  committed
  0028651

  Copy full SHA for 0028651

• Add both systems in parallel

  GrahamTheCoder

  committed
  e84508b

  Copy full SHA for e84508b

• Port at end - 17 fail

  GrahamTheCoder

  committed
  e9a0308

  Copy full SHA for e9a0308

• Stop keeping track of replaced target

  GrahamTheCoder

  committed
  562223c

  Copy full SHA for 562223c

• Stop mutating local target parameter

  GrahamTheCoder

  committed
  2ad9529

  Copy full SHA for 2ad9529

• Rename

  GrahamTheCoder

  committed
  da09e0f

  Copy full SHA for da09e0f

• Inline

  GrahamTheCoder

  committed
  4118fb7

  Copy full SHA for 4118fb7

• Put in todos for plans

  GrahamTheCoder

  committed
  1312391

  Copy full SHA for 1312391

• Consolidate logic down since the split isn't that helpful

  GrahamTheCoder

  committed
  1ab1d17

  Copy full SHA for 1ab1d17

• Fix typo - 11 fail

  GrahamTheCoder

  committed
  37fc8db

  Copy full SHA for 37fc8db

• Recharacterize C#

  GrahamTheCoder

  committed
  d35f629

  Copy full SHA for d35f629

• Split accumulating trivia from placing. Pick only within source line.

  GrahamTheCoder

  committed
  eba86eb

  Copy full SHA for eba86eb

• Comment moved block - 7 fail

  GrahamTheCoder

  committed
  788f0d8

  Copy full SHA for 788f0d8

Commits on Feb 3, 2020

• Comment this moved expression

  GrahamTheCoder

  committed
  32a18ba

  Copy full SHA for 32a18ba

• SelectMany and other tidyups

  GrahamTheCoder

  committed
  b161b72

  Copy full SHA for b161b72

• Rename to admit these are cs functions

  GrahamTheCoder

  committed
  d61ad15

  Copy full SHA for d61ad15

• Balance trivia - 5 tests fail

  GrahamTheCoder

  committed
  63c2f29

  Copy full SHA for 63c2f29

• Tidy up

  GrahamTheCoder

  committed
  669b20f

  Copy full SHA for 669b20f

• Fall back on alternate dictionary

  Show description for 1bc0ec0
  GrahamTheCoder

  committed
  1bc0ec0

  Copy full SHA for 1bc0ec0

• Formatting/naming

  GrahamTheCoder

  committed
  7b6d0c3

  Copy full SHA for 7b6d0c3

• Fix disabling of source map where it isn't the original token position

  GrahamTheCoder

  committed
  21c37c2

  Copy full SHA for 21c37c2

• Note limitation of this approach

  GrahamTheCoder

  committed
  aa49d3c

  Copy full SHA for aa49d3c

• Remove bits that don't make any tests fail

  GrahamTheCoder

  committed
  a057032

  Copy full SHA for a057032

• Merge remote-tracking branch 'origin/master' into rewrite-method-trivia

  Show description for f259f76
  GrahamTheCoder

  committed
  f259f76

  Copy full SHA for f259f76

• Remove unused using

  GrahamTheCoder

  committed
  a1ff5b6

  Copy full SHA for a1ff5b6

• Characterize comments

  GrahamTheCoder

  committed
  176ca5e

  Copy full SHA for 176ca5e

• Revert accidental behaviour change

  GrahamTheCoder

  committed
  f8475a9

  Copy full SHA for f8475a9

• Fix broken input

  GrahamTheCoder

  committed
  7831c0d

  Copy full SHA for 7831c0d

• Revert unncessary changes

  GrahamTheCoder

  committed
  5c66b33

  Copy full SHA for 5c66b33