-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port trivia line by line C# -> VB #512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will handle #if directives separately since they will need tree rewriting and speculative semantic models to convert correctly
4f96bf1
to
4845a75
Compare
Recent improvements mean it may not be needed, and I'd rather add back something just covering the necessary cases
4845a75
to
f7d0efc
Compare
Avoid bug where the expander lost part of the name
leading trivia for a line should definitely appear before trailing trivia for it, and vice versa
# Conflicts: # ICSharpCode.CodeConverter/VB/CommonConversions.cs # ICSharpCode.CodeConverter/VB/NodesVisitor.cs # Tests/VB/ExpressionTests.cs # Tests/VB/NamespaceLevelTests.cs # Tests/VB/StandaloneStatementTests.cs # Tests/VB/TypeCastTests.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The focus here is not losing any comments - getting all of them into the result in roughly the order, and within a line or so of where they were in the source. To understand why this is a bit vague, take the example of a for loop in C#, which sometimes needs to turn into a while loop in VB:
Some source code:
The conversion we might hope for:
Obviously we can't know whether the comment was regarding the condition or the increment expression. This PR keeps the comment with the closest expression wherever possible. (i.e. the first case will work, the second will look a bit wrong)
To do