-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend RestrictedSecurity constraints #935
Extend RestrictedSecurity constraints #935
Conversation
0e832f3
to
67cd84a
Compare
f71ed5a
to
f42c9c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should support more than one use for any given algorithm. For example, we might want to allow both UUID and TestConstraintsSuccess to use MD5:
{MessageDigest, MD5, *, ModuleAndFullClassName:java.base/java.util.UUID, FullClassName:TestConstraintsSuccess}
(ignore for the moment whether comma is the right separator for acceptable uses)
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Outdated
Show resolved
Hide resolved
closed/test/jdk/openj9/internal/security/TestConstraintsFailure.java
Outdated
Show resolved
Hide resolved
closed/test/jdk/openj9/internal/security/TestConstraintsFailure.java
Outdated
Show resolved
Hide resolved
closed/test/jdk/openj9/internal/security/TestConstraintsFailure.java
Outdated
Show resolved
Hide resolved
closed/test/jdk/openj9/internal/security/TestConstraintsFailure.java
Outdated
Show resolved
Hide resolved
closed/test/jdk/openj9/internal/security/TestConstraintsSuccess.java
Outdated
Show resolved
Hide resolved
We considered this as an option, but we came to the conclusion that it might become convoluted and is kind of error prone. Instead, one can have multiple constraints per algorithm. For example:
|
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Outdated
Show resolved
Hide resolved
closed/test/jdk/openj9/internal/security/TestConstraintsFailure.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash.
The functionality of the provider constraints in RestrictedSecurity profiles is extended. Instead of allowing them to be universally used, one can optionally indicate the specific module and/or class from where a particular cryptographic algorithm can be called. Tests are, also, added to test the new functionality offered through RestrictedSecurity profiles. Signed-off-by: Kostas Tsiounis <[email protected]>
5cb4c5a
to
4237eac
Compare
Jenkins test sanity alinux jdknext |
The sanity.openjdk failure should be resolved by adoptium/ci-jenkins-pipelines#1191. |
The functionality of the provider constraints in
RestrictedSecurity
profiles is extended. Instead of allowing them to be universally used, one can optionally indicate the specific module and/or class from where a particular cryptographic algorithm can be called.Tests are, also, added to test the new functionality offered through
RestrictedSecurity
profiles.Signed-off-by: Kostas Tsiounis [email protected]