-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jtreg.sh - use jdk11 instead of jdk-11 #1191
Conversation
Signed-off-by: Stewart X Addison <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
run tests 8,21 |
Signed-off-by: Stewart X Addison <[email protected]>
nit, that PR was to add jtreg 7.5+1 to the set of available versions. |
Fixed |
I've pushed another commit to fix a similar failure in the |
This should fix #1190. |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
run tests |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
The failure on Windows appears unrelated to this change. Could that job be restarted, perhaps? |
Yeah that was a machine-specific issue with a locked directory so I am unconcerned about it. Re-running at https://ci.adoptium.net/job/build-scripts-pr-tester/job/build-test/job/jobs/job/jdk8u/job/jdk8u-windows-x64-temurin/220/console although that won't show up in the checks. Still requires another formal reviewer so assigning Andrew as a reviewer. |
Rerun was good, merging. |
https://ci.adoptium.net/job/dependency_pipeline/1474/ is green (First in a long time!) |
The dependencyPipeline job has been failing since November e.g. https://ci.adoptium.net/job/dependency_pipeline/1464/execution/node/161/log/?consoleFull
This has resulted in the PR to update to jtreg 7.1+1 to fail to go live.
The underlying reason for this appears to be because that job is utilising the adoptium build_image docker containers (which I wasn't aware of) and they were changed to use
jdkXX
instead ofjdk-XX
for the name of the JDK directory under/usr/lib/jvm
for better compatibility with the upstream openjdk builds.This PR adjusts the jtreg.sh script so that it uses the
jdkXX
paths without the hyphen.Temporary test job with the fix: https://ci.adoptium.net/job/sxa-deppipe/1/execution/node/148/log/