zipl: add value of target= as search path for BLS case #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the BLS files, the 'linux' and 'initrd' fields are relative to the $BOOT directory. If $BOOT is a mount point of boot partition, 'linux' and 'initrd' fields are relative to boot partition. If not, the paths are relative to $BOOT directory of root partition. zipl always starts searching at / regardless of partitions and mount points. This commit extends the semantics of target= field in zipl.conf to make it as a second search path, besides /, for those 2 BLS fields. See issues ibm-s390-linux#69 for more details. Fixes: ibm-s390-linux#69 Signed-off-by: Tuan Hoang <[email protected]>
tuan-hoang1
force-pushed
the
bls-target
branch
from
004bafd to
e2f02d0
Compare
|
Force pushes are to fix commit message, no functional change. |
|
Hi, thanks a lot for the contribution. From reading the Code it looks good to me. I will give it a test and include it if there is no additional finding. Regards, |
tuan-hoang1
added a commit
to tuan-hoang1/ignition-dracut
that referenced
this pull request
Oct 10, 2019
zipl records need to be updated, because ignition.firstboot is burned into target disk during coreos-installer As a short-term solution for: coreos#84 Depends on: ibm-s390-linux/s390-tools#71 ibm-s390-linux/s390-tools#74 Related: coreos/coreos-installer#61 coreos/coreos-assembler#780
tuan-hoang1
added a commit
to tuan-hoang1/ignition-dracut
that referenced
this pull request
Oct 11, 2019
zipl records need to be updated, because ignition.firstboot is burned into target disk during coreos-installer As a short-term solution for: coreos#84 Depends on: ibm-s390-linux/s390-tools#71 ibm-s390-linux/s390-tools#74 Related: coreos/coreos-installer#61 coreos/coreos-assembler#780
33 tasks
tuan-hoang1
added a commit
to tuan-hoang1/ignition-dracut
that referenced
this pull request
Nov 6, 2019
zipl records need to be updated, because ignition.firstboot is burned into target disk during coreos-installer As a short-term solution for: coreos#84 Depends on: ibm-s390-linux/s390-tools#71 ibm-s390-linux/s390-tools#74 Related: coreos/coreos-installer#61 coreos/coreos-assembler#780
jlebon
pushed a commit
to coreos/ignition-dracut
that referenced
this pull request
Nov 6, 2019
zipl records need to be updated, because ignition.firstboot is burned into target disk during coreos-installer As a short-term solution for: #84 Depends on: ibm-s390-linux/s390-tools#71 ibm-s390-linux/s390-tools#74 Related: coreos/coreos-installer#61 coreos/coreos-assembler#780
Prashanth684
pushed a commit
to Prashanth684/ignition-dracut
that referenced
this pull request
Nov 28, 2019
zipl records need to be updated, because ignition.firstboot is burned into target disk during coreos-installer As a short-term solution for: coreos#84 Depends on: ibm-s390-linux/s390-tools#71 ibm-s390-linux/s390-tools#74 Related: coreos/coreos-installer#61 coreos/coreos-assembler#780 (cherry picked from commit 38af701)
jlebon
pushed a commit
to coreos/ignition-dracut
that referenced
this pull request
Nov 28, 2019
zipl records need to be updated, because ignition.firstboot is burned into target disk during coreos-installer As a short-term solution for: #84 Depends on: ibm-s390-linux/s390-tools#71 ibm-s390-linux/s390-tools#74 Related: coreos/coreos-installer#61 coreos/coreos-assembler#780 (cherry picked from commit 38af701)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the BLS files, the 'linux' and 'initrd' fields are relative to the
$BOOT directory. If $BOOT is a mount point of boot partition, 'linux'
and 'initrd' fields are relative to boot partition. If not, the paths
are relative to $BOOT directory of root partition.
zipl always starts searching at / regardless of partitions and mount
points.
This commit extends the semantics of target= field in zipl.conf to make
it as a second search path, besides /, for those 2 BLS fields.
See issues #69 for more details.
Fixes: #69
Signed-off-by: Tuan Hoang [email protected]