-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zipl: check multiple locations of zipl.conf, ship a minimal zipl.conf #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
reviewed
Oct 1, 2019
Allow zipl to find zipl.conf in following order: /run/zipl/zipl.conf /etc/zipl.conf /lib/s390-tools/zipl.conf Whichever is found first will be used. Fixes: ibm-s390-linux#70 Signed-off-by: Tuan Hoang <[email protected]>
9eab3f7
to
b975a9b
Compare
Ship a minimal zipl configuration file at /lib/s390-tools/zipl.conf by default which would help systems using BLS files, without having to create the traditional /etc/zipl.conf file. Fixes: ibm-s390-linux#70 Signed-off-by: Tuan Hoang <[email protected]>
The last 2 force pushes were for fixing man pages. This should be ready by now. |
martinezjavier
approved these changes
Oct 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
lucab
reviewed
Oct 8, 2019
Hi, thanks a lot for the cotribution. From reading the Code it looks good to me. I will give it a test and include it if there is no additional finding. Regards, |
tuan-hoang1
added a commit
to tuan-hoang1/ignition-dracut
that referenced
this pull request
Oct 10, 2019
zipl records need to be updated, because ignition.firstboot is burned into target disk during coreos-installer As a short-term solution for: coreos#84 Depends on: ibm-s390-linux/s390-tools#71 ibm-s390-linux/s390-tools#74 Related: coreos/coreos-installer#61 coreos/coreos-assembler#780
tuan-hoang1
added a commit
to tuan-hoang1/ignition-dracut
that referenced
this pull request
Oct 11, 2019
zipl records need to be updated, because ignition.firstboot is burned into target disk during coreos-installer As a short-term solution for: coreos#84 Depends on: ibm-s390-linux/s390-tools#71 ibm-s390-linux/s390-tools#74 Related: coreos/coreos-installer#61 coreos/coreos-assembler#780
hoeppnerj
pushed a commit
that referenced
this pull request
Oct 17, 2019
Ship a minimal zipl configuration file at /lib/s390-tools/zipl.conf by default which would help systems using BLS files, without having to create the traditional /etc/zipl.conf file. GitHub-ID: #70 GitHub-ID: #71 Signed-off-by: Tuan Hoang <[email protected]> Signed-off-by: Stefan Haberland <[email protected]> Signed-off-by: Jan Höppner <[email protected]>
33 tasks
tuan-hoang1
added a commit
to tuan-hoang1/ignition-dracut
that referenced
this pull request
Nov 6, 2019
zipl records need to be updated, because ignition.firstboot is burned into target disk during coreos-installer As a short-term solution for: coreos#84 Depends on: ibm-s390-linux/s390-tools#71 ibm-s390-linux/s390-tools#74 Related: coreos/coreos-installer#61 coreos/coreos-assembler#780
jlebon
pushed a commit
to coreos/ignition-dracut
that referenced
this pull request
Nov 6, 2019
zipl records need to be updated, because ignition.firstboot is burned into target disk during coreos-installer As a short-term solution for: #84 Depends on: ibm-s390-linux/s390-tools#71 ibm-s390-linux/s390-tools#74 Related: coreos/coreos-installer#61 coreos/coreos-assembler#780
Prashanth684
pushed a commit
to Prashanth684/ignition-dracut
that referenced
this pull request
Nov 28, 2019
zipl records need to be updated, because ignition.firstboot is burned into target disk during coreos-installer As a short-term solution for: coreos#84 Depends on: ibm-s390-linux/s390-tools#71 ibm-s390-linux/s390-tools#74 Related: coreos/coreos-installer#61 coreos/coreos-assembler#780 (cherry picked from commit 38af701)
jlebon
pushed a commit
to coreos/ignition-dracut
that referenced
this pull request
Nov 28, 2019
zipl records need to be updated, because ignition.firstboot is burned into target disk during coreos-installer As a short-term solution for: #84 Depends on: ibm-s390-linux/s390-tools#71 ibm-s390-linux/s390-tools#74 Related: coreos/coreos-installer#61 coreos/coreos-assembler#780 (cherry picked from commit 38af701)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #70
#70