-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minor] Add manage onlineUpgrade cronjob #238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomklapiscak
reviewed
Dec 5, 2024
instance-applications/510-550-ibm-mas-suite-app-config/templates/02-ibm-manage-update_Job.yaml
Show resolved
Hide resolved
tomklapiscak
previously approved these changes
Dec 5, 2024
tomklapiscak
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jsw.ibm.com/browse/MASCORE-4544
Adds a new cronjob that can be set to a schedule (defaults to midnight every night), that will run and check if there is an offline update pending for Manage. This is only used when the manage ws spec has
settings.db.upgrade.upgradeType
set toonlineUpgrade
.If there is no pending update then the job exits doing nothing. If there is one pending then it patches the ManageOfflineUpgradeRequest resource with the
stage
requested. this will then cause the Manage workspace operator to bring down the serverbundles and update them. It will also remove the status from the ManageOfflineUpgradeRequest as this was causing problems with the manage operator when it was trying to detect what needs to happen. If the status is not present then it doesn't try to remove it.See also PR ibm-mas/cli#1391
Tested with the default schedule and a provided schedule, and the cronjob is created/recreated in both cases:
When the job does run this is the output:

Also tested: