[minor] Add manage onlineUpgrade support for gitops + skip deprovision tasks based on edition #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitfiea
requested review from
durera,
JonahLuckett,
andrercm,
sanjayprab,
terenceq,
alequint and
leo-miran
as code owners
tomklapiscak
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the manage onlineUpgrade cronjob, that will automatically run the offlineupdate phase of manage based on a schedule. The schedule defaults to midnight each night, but this PR gives the option to override it. See ibm-mas/gitops#238 for more details. https://jsw.ibm.com/browse/MASCORE-4544
This PR also adds support to skip some deprovision tasks for apps that won't be in a certain edition, as were just no-ops buy consumed resource to run. https://jsw.ibm.com/browse/MASCORE-4622
Lastly, the DB2 change is to remove the db2 archive and temp entries in the template if the storageclass is not set. These are optional, but the fact that the keys are still present (with no value) was causing some confusion. https://jsw.ibm.com/browse/MASCORE-4614