Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Allow Mongodb update to use already configured storageclass #674

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

racree
Copy link
Contributor

@racree racree commented Dec 1, 2023

When "mas update" is run, mongodb community update needs to respect the existing storage class and not change it.

@racree
Copy link
Contributor Author

racree commented Dec 1, 2023

To test this pull request, I deployed MAS using catalog v8-231004-amd64 and specified custom storage class of "custom-ceph-rbd". I then ran "mas update" and chose the v8-231128-amd64 catalog. The comparison of MongoDBCommunity CRs shows mongodb version was upgraded from 4.4.21 to 5.0.21 and the storageClassName correctly remained the same "custom-ceph-rbd"

Screenshot 2023-11-30 at 8 58 23 PM

And "mas update" was successful.

Screenshot 2023-11-30 at 9 25 24 PM

@racree
Copy link
Contributor Author

racree commented Dec 1, 2023

I also tested this by running mas install with the v8-231004-amd64 catalog and subsequently running "mas update" and specifying the v8-231031-amd64 catalog. As shown below, the MongoDBCommunity CR version remained 4.4.21 and the storageClassName correctly remained "custom-ceph-rbd"

Screenshot 2023-11-30 at 9 57 59 PM

mas update was successful.

Screenshot 2023-11-30 at 9 55 42 PM

@racree
Copy link
Contributor Author

racree commented Dec 1, 2023

NOTE: This PR does not depend on any code changes in ansible-devops.

@whitfiea whitfiea changed the title Mongodb update [minor] Allow Mongodb update to use already configured storageclass Dec 1, 2023
@whitfiea whitfiea merged commit 1f4737a into master Dec 1, 2023
@whitfiea whitfiea deleted the mongodb-update2 branch December 1, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants