[patch] Do not validate storage class for mongo update

[racree]

Storage class isn't set in the update pipeline. The mongo role just needs to not do anything with storage classes in the action=update path, update doesn't need to change the storage.

Therefore the update action should not call tasks/determine-storage-classes.yml

[racree]

ran "mas install" specifying catalog from Aug 29, 2023

MongoDB successfully installed

Then ran "mas update" specifying catalog from Oct 4, 2023

Update pipeline successfully ran

[andrercm]

makes sense to me

[whitfiea]

@racree I am not sure I understand how this fixes the problem stated, which was to not validate the storage class for mongo?

For the upgrade flow, it will call install, and if the install needs to upgrade (say from 0.7.8 to 0.7.9) then it will install this new CR https://github.com/ibm-mas/ansible-devops/blob/master/ibm/mas_devops/roles/mongodb/templates/community/0.7.9/cr.yml.j2#L75C35-L75C56 which has the mongodb storage class. So either the update needs to know the storage class or it has to read what the current storageclass is and set that in the new CR.

[racree]

@whitfiea Does this PR need to be written differently? My original understanding was... when Mongo is already installed and running, we do not need to validate the storage class because we should not be changing the storage class. But based on your comment above, you are expecting something different?

[racree]

@whitfiea I think I understand what you are saying... it is not enough to skip calling "tasks/determine-storage-classes" because the cr that gets applied during the update requires mongodb_storage_class to be defined.

[racree]

fixed in ibm-mas/cli#674