-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minor] Review fvt-launcher design for manage and its dependencies #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-miran
approved these changes
Jun 14, 2024
sanjayprab
approved these changes
Jun 17, 2024
karol-czarnecki
added a commit
that referenced
this pull request
Jun 21, 2024
commit 57a7d4e Author: André Marcelino <[email protected]> Date: Thu Jun 20 17:09:35 2024 -0300 [patch] remove optimizer-manage-setup test (#1046) commit 5d0a4ba Author: Jon Levell <[email protected]> Date: Thu Jun 20 09:24:29 2024 +0100 [patch] mustgather: collect iot messaging proxy trace (#1043) commit 742acc2 Author: Ian Boden <[email protected]> Date: Tue Jun 18 02:05:08 2024 +0100 [patch] Fix IoT approval conditional in FVT launcher (#978) Co-authored-by: David Parker <[email protected]> commit 3030b05 Author: Alexandre Quinteiro <[email protected]> Date: Mon Jun 17 21:56:28 2024 -0300 [patch] Use ignore_failure param in wait task (#1028) commit 43da893 Author: David Parker <[email protected]> Date: Tue Jun 18 01:55:22 2024 +0100 [patch] Convert upgrade & uninstall functions to Python (#1038) commit f2e77ba Author: leo-miran <[email protected]> Date: Mon Jun 17 18:40:26 2024 -0300 [minor] mobile version finder (#1030) Co-authored-by: Alexandre Quinteiro <[email protected]> commit 4894573 Author: Alexandre Quinteiro <[email protected]> Date: Mon Jun 17 10:17:44 2024 -0300 [minor] Review fvt-launcher design for manage and its dependencies (#1025) Co-authored-by: Alexandre Quinteiro <[email protected]> Co-authored-by: unnati-solanki-git <[email protected]> commit 0d48ef2 Author: Sanjay Prabhakar <[email protected]> Date: Mon Jun 17 11:10:19 2024 +0100 [patch] push latest tagged image to quay.io (#1036) commit 6ae7716 Author: Sanjay Prabhakar <[email protected]> Date: Mon Jun 17 11:04:28 2024 +0100 [patch] workaround for pushing image action in release (#1035) commit 3c79035 Author: Lokesh <[email protected]> Date: Sat Jun 15 17:23:29 2024 -0400 [patch] incorrect namespace being passed on from cli to ansible-devop from teckton (#1034) commit 3e523f5 Author: yuvraj-vansure <[email protected]> Date: Fri Jun 14 23:49:51 2024 +0530 [minor] User defined DRO namespace (#1024) Co-authored-by: Yuvraj Vansure <yuvraj.vansure1.ibm.com> commit e2e9d54 Author: Sanjay Prabhakar <[email protected]> Date: Thu Jun 13 01:54:32 2024 +0100 [patch] Temporay workaround to fix image push action (#1027) Co-authored-by: Sanjay Prabhakar <[email protected]> commit 50b1633 Author: Harsh Tamakuwala <[email protected]> Date: Mon Jun 10 13:27:53 2024 +0530 [patch] Fixes pipeline to pass podTemplates to FVT test case (#1013) commit efdecf4 Author: leo-miran <[email protected]> Date: Fri Jun 7 12:53:32 2024 -0300 [patch] updating base_output_dir in mg template (#1020) commit 676c43b Author: leo-miran <[email protected]> Date: Thu Jun 6 20:41:52 2024 -0300 [patch] must-gather file path change for upgrade pipeline (#1015) Co-authored-by: Alexandre Quinteiro <[email protected]> commit 5301e8f Author: anilprajapatiibm <[email protected]> Date: Wed Jun 5 19:14:51 2024 +0530 [minor] Support May Catalog update (#953) Co-authored-by: Sanjay Prabhakar <[email protected]> commit c8eff24 Author: unnati-solanki-git <[email protected]> Date: Wed Jun 5 09:26:24 2024 +0530 [patch] Install COS and Kafka when Manage is present (#1010) Co-authored-by: Alexandre Quinteiro <[email protected]> Co-authored-by: Alexandre Quinteiro <[email protected]> commit 5875637 Author: Alexandre Quinteiro <[email protected]> Date: Mon Jun 3 08:05:28 2024 -0300 [minor] Add install sync point at the end of fvt-launcher (#996) commit b0fce77 Author: liyongc <[email protected]> Date: Mon Jun 3 18:03:19 2024 +0800 [minor]Add podTemplates for manage accelerator (#998) commit 103b942 Author: prakrutishah06 <[email protected]> Date: Mon Jun 3 15:22:17 2024 +0530 [patch] Remove esig-basic keyword from last phase (#959) commit 6bb36f9 Author: unnati-solanki-git <[email protected]> Date: Fri May 31 20:44:30 2024 +0530 [minor] Merge health launcher into manage-is and re-organize some selenium tests (#999) Co-authored-by: Alexandre Quinteiro <[email protected]> Co-authored-by: Alexandre Quinteiro <[email protected]> commit 3f10822 Author: Alona Varshal <[email protected]> Date: Thu May 30 04:21:42 2024 -0500 [patch] Doc update for catalog guidance (#1005)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
base-api-setup
outside fvt-manage and make fvt-manage, fvt-manage-is and fvt-optimizer depend on itCompleted
. Besides that, we should also makeFailed
as a escape route and thenwaitfor-configmap
logic will fail pipeline earlierEvidences
About fvt-manage-is
Before:
After (in 4 phases):
Reintroduce Manage IS + Manage Setup move
Escape Route in fvt-launcher's waitfor-installation
Considering configmap, key and value to watch:
... added a escape route against the same map:
During the iteration, If value is not
Completed
, we check if that key assumed any different value, likeFailed
. And asFailed
is different fromCompleted
and we are not ignoring failures, task will exit in error earlier than timeout.In addition, as per slack conversation here,
wait-for-configmap
has been slightly changed to consider input of config map value with more than one value (i.e.Completed
andSucceeded
)About wait-for-install Tasks in Layer 4 pipelines
Evidence during uninstall pipeline (note use of wait-for-pipelinerun, repeating checking every 600 seconds, as opposed to old wait-for-install, using
oc condition
with 12h timeout:Note: ansible-FVT PR supporting changes above: https://github.ibm.com/maximoappsuite/ansible-fvt/pull/433
Final Test
FVT Launcher has launched all the things properly in the right sequence:
Manage Industry Solutions pipeline running as expected (including Health):
Finally, IVT Pipeline running after manage and monitor FVTs are finished:
Note: in the screenshot we see approval-manange did not run. That is because I had not updated
when
criteria of that task as I did with waitfor-manage. The criteria did not consider manage-is launcher to run, only manage and mobile (and both are false in this run). I did this correction in a subsequent commit here: f04377bTest evidence of the final sync install step in FVT Launcher, where code was modified to receive two possible target values for the config-mal key:
And here indicates that install pipeline set it up with
Completed