Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] Install COS and Kafka when Manage is present #1010

Merged
merged 8 commits into from
Jun 5, 2024
Merged

[patch] Install COS and Kafka when Manage is present #1010

merged 8 commits into from
Jun 5, 2024

Conversation

unnati-solanki-git
Copy link
Contributor

... and when COS and Kafka appropriated parameters are informed.

This is needed because Manage can optionally use Kafka and COS internally. And we have FVTs to test these cases.

Tested in pfvtcisquad, run 1167: https://dashboard.masdev.wiotp.sl.hursley.ibm.com/tests/pfvtcisquad

@unnati-solanki-git unnati-solanki-git marked this pull request as draft June 3, 2024 13:02
@alequint alequint marked this pull request as ready for review June 3, 2024 14:19
@alequint alequint marked this pull request as draft June 3, 2024 14:28
@alequint alequint mentioned this pull request Jun 3, 2024
Closed
@alequint alequint marked this pull request as ready for review June 3, 2024 16:41
@alequint
Copy link
Contributor

alequint commented Jun 3, 2024

Some more context discussed in slack about this PR. This change would be a part 1 of 2 parts:

I was trying to think in a two parts push here as we need COS for Manage and Mobile FVTs, considering COS (and Kafka, which came as bonus here in the PR) is actually an optional service to be used:

  • Part 1 (current PR): would be just to make sure COS is part FVT environments, so correspondent FVTs can connect to those services and do what they need. This change would not impact existing CLI flows, because besides installing Manage, pipeline would need to setup cos_type or kafka_action params to make it work (and so pass the task when clauses), which we do not have have in manage installation flow in CLI today (it does in Assist or in IoT/Monitor side only, respectively).

  • Part 2: then we would need to bring to CLI flow the optional use of COS or Kafka when someone installs Manage. That flow will set cos_type and kafka_action properly during Manage flow (and also the different type of configs). I just let this one to be done once 1 is in use for FVT because it consumes more time to develop and test - still in this part 2 would be required the enhancement of suite-app-config we talked elsewhere, where we discuss the multiple manage settings that happen after ManageWorkspace is installed (we would need the enhanced suite-app-config setup CR upfront, instead of setting it later causing unnecessary reconciles).

Giving the above, how you feel about these two parts being handled separately @durera ? (installation as part 1 with no impact in existing flow X configuration a part 2, to parameterize pipeline properly from Manage CLI installation flow to also configure attachments feature to use it)

@alequint alequint self-requested a review June 4, 2024 01:52
@alequint
Copy link
Contributor

alequint commented Jun 5, 2024

Just one more comment about the run of CLI using this version of pipeline:

docker run -ti --rm -v ~/Documents/projects/mas/masconfig:/mnt/home --pull always quay.io/ibmmas/cli:9.2.1-pre.managecosus

Note just Manage is installed (no Assist, no IoT):

image

And in Pipeline, neither costype nor kafka action has been set, skipping COS and Kafka installation:

image image

Part 2 mentioned above will be included section 8.1 of CLI, Configure Maximo Manage, so users can decide how to setup attachments.

@alequint alequint merged commit c8eff24 into master Jun 5, 2024
3 checks passed
@alequint alequint deleted the managecosus branch June 5, 2024 03:56
karol-czarnecki added a commit that referenced this pull request Jun 17, 2024
@karol-czarnecki
Squashed commit of the following:
c7a3208 
commit 0d48ef2
Author: Sanjay Prabhakar <[email protected]>
Date:   Mon Jun 17 11:10:19 2024 +0100

    [patch] push latest tagged image to quay.io (#1036)

commit 6ae7716
Author: Sanjay Prabhakar <[email protected]>
Date:   Mon Jun 17 11:04:28 2024 +0100

    [patch] workaround for pushing image action in release (#1035)

commit 3c79035
Author: Lokesh <[email protected]>
Date:   Sat Jun 15 17:23:29 2024 -0400

    [patch] incorrect namespace being passed on from cli to ansible-devop from teckton (#1034)

commit 3e523f5
Author: yuvraj-vansure <[email protected]>
Date:   Fri Jun 14 23:49:51 2024 +0530

    [minor] User defined DRO namespace (#1024)

    Co-authored-by: Yuvraj Vansure <yuvraj.vansure1.ibm.com>

commit e2e9d54
Author: Sanjay Prabhakar <[email protected]>
Date:   Thu Jun 13 01:54:32 2024 +0100

    [patch] Temporay workaround to fix image push action (#1027)

    Co-authored-by: Sanjay Prabhakar <[email protected]>

commit 50b1633
Author: Harsh Tamakuwala <[email protected]>
Date:   Mon Jun 10 13:27:53 2024 +0530

    [patch] Fixes pipeline to pass podTemplates to FVT test case (#1013)

commit efdecf4
Author: leo-miran <[email protected]>
Date:   Fri Jun 7 12:53:32 2024 -0300

    [patch] updating base_output_dir in mg template (#1020)

commit 676c43b
Author: leo-miran <[email protected]>
Date:   Thu Jun 6 20:41:52 2024 -0300

    [patch] must-gather file path change for upgrade pipeline (#1015)

    Co-authored-by: Alexandre Quinteiro <[email protected]>

commit 5301e8f
Author: anilprajapatiibm <[email protected]>
Date:   Wed Jun 5 19:14:51 2024 +0530

    [minor] Support May Catalog update (#953)

    Co-authored-by: Sanjay Prabhakar <[email protected]>

commit c8eff24
Author: unnati-solanki-git <[email protected]>
Date:   Wed Jun 5 09:26:24 2024 +0530

    [patch] Install COS and Kafka when Manage is present (#1010)

    Co-authored-by: Alexandre Quinteiro <[email protected]>
    Co-authored-by: Alexandre Quinteiro <[email protected]>

commit 5875637
Author: Alexandre Quinteiro <[email protected]>
Date:   Mon Jun 3 08:05:28 2024 -0300

    [minor] Add install sync point at the end of fvt-launcher (#996)

commit b0fce77
Author: liyongc <[email protected]>
Date:   Mon Jun 3 18:03:19 2024 +0800

    [minor]Add podTemplates for manage accelerator (#998)

commit 103b942
Author: prakrutishah06 <[email protected]>
Date:   Mon Jun 3 15:22:17 2024 +0530

    [patch] Remove esig-basic keyword from last phase  (#959)

commit 6bb36f9
Author: unnati-solanki-git <[email protected]>
Date:   Fri May 31 20:44:30 2024 +0530

    [minor] Merge health launcher into manage-is and re-organize some selenium tests (#999)

    Co-authored-by: Alexandre Quinteiro <[email protected]>
    Co-authored-by: Alexandre Quinteiro <[email protected]>

commit 3f10822
Author: Alona Varshal <[email protected]>
Date:   Thu May 30 04:21:42 2024 -0500

    [patch] Doc update for catalog guidance (#1005)
karol-czarnecki added a commit that referenced this pull request Jun 21, 2024
@karol-czarnecki
Squashed commit of the following:
5e1fd7d 
commit 57a7d4e
Author: André Marcelino <[email protected]>
Date:   Thu Jun 20 17:09:35 2024 -0300

    [patch] remove optimizer-manage-setup test (#1046)

commit 5d0a4ba
Author: Jon Levell <[email protected]>
Date:   Thu Jun 20 09:24:29 2024 +0100

    [patch] mustgather: collect iot messaging proxy trace (#1043)

commit 742acc2
Author: Ian Boden <[email protected]>
Date:   Tue Jun 18 02:05:08 2024 +0100

    [patch] Fix IoT approval conditional in FVT launcher (#978)

    Co-authored-by: David Parker <[email protected]>

commit 3030b05
Author: Alexandre Quinteiro <[email protected]>
Date:   Mon Jun 17 21:56:28 2024 -0300

    [patch] Use ignore_failure param in wait task (#1028)

commit 43da893
Author: David Parker <[email protected]>
Date:   Tue Jun 18 01:55:22 2024 +0100

    [patch] Convert upgrade & uninstall functions to Python (#1038)

commit f2e77ba
Author: leo-miran <[email protected]>
Date:   Mon Jun 17 18:40:26 2024 -0300

    [minor] mobile version finder (#1030)

    Co-authored-by: Alexandre Quinteiro <[email protected]>

commit 4894573
Author: Alexandre Quinteiro <[email protected]>
Date:   Mon Jun 17 10:17:44 2024 -0300

    [minor] Review fvt-launcher design for manage and its dependencies (#1025)

    Co-authored-by: Alexandre Quinteiro <[email protected]>
    Co-authored-by: unnati-solanki-git <[email protected]>

commit 0d48ef2
Author: Sanjay Prabhakar <[email protected]>
Date:   Mon Jun 17 11:10:19 2024 +0100

    [patch] push latest tagged image to quay.io (#1036)

commit 6ae7716
Author: Sanjay Prabhakar <[email protected]>
Date:   Mon Jun 17 11:04:28 2024 +0100

    [patch] workaround for pushing image action in release (#1035)

commit 3c79035
Author: Lokesh <[email protected]>
Date:   Sat Jun 15 17:23:29 2024 -0400

    [patch] incorrect namespace being passed on from cli to ansible-devop from teckton (#1034)

commit 3e523f5
Author: yuvraj-vansure <[email protected]>
Date:   Fri Jun 14 23:49:51 2024 +0530

    [minor] User defined DRO namespace (#1024)

    Co-authored-by: Yuvraj Vansure <yuvraj.vansure1.ibm.com>

commit e2e9d54
Author: Sanjay Prabhakar <[email protected]>
Date:   Thu Jun 13 01:54:32 2024 +0100

    [patch] Temporay workaround to fix image push action (#1027)

    Co-authored-by: Sanjay Prabhakar <[email protected]>

commit 50b1633
Author: Harsh Tamakuwala <[email protected]>
Date:   Mon Jun 10 13:27:53 2024 +0530

    [patch] Fixes pipeline to pass podTemplates to FVT test case (#1013)

commit efdecf4
Author: leo-miran <[email protected]>
Date:   Fri Jun 7 12:53:32 2024 -0300

    [patch] updating base_output_dir in mg template (#1020)

commit 676c43b
Author: leo-miran <[email protected]>
Date:   Thu Jun 6 20:41:52 2024 -0300

    [patch] must-gather file path change for upgrade pipeline (#1015)

    Co-authored-by: Alexandre Quinteiro <[email protected]>

commit 5301e8f
Author: anilprajapatiibm <[email protected]>
Date:   Wed Jun 5 19:14:51 2024 +0530

    [minor] Support May Catalog update (#953)

    Co-authored-by: Sanjay Prabhakar <[email protected]>

commit c8eff24
Author: unnati-solanki-git <[email protected]>
Date:   Wed Jun 5 09:26:24 2024 +0530

    [patch] Install COS and Kafka when Manage is present (#1010)

    Co-authored-by: Alexandre Quinteiro <[email protected]>
    Co-authored-by: Alexandre Quinteiro <[email protected]>

commit 5875637
Author: Alexandre Quinteiro <[email protected]>
Date:   Mon Jun 3 08:05:28 2024 -0300

    [minor] Add install sync point at the end of fvt-launcher (#996)

commit b0fce77
Author: liyongc <[email protected]>
Date:   Mon Jun 3 18:03:19 2024 +0800

    [minor]Add podTemplates for manage accelerator (#998)

commit 103b942
Author: prakrutishah06 <[email protected]>
Date:   Mon Jun 3 15:22:17 2024 +0530

    [patch] Remove esig-basic keyword from last phase  (#959)

commit 6bb36f9
Author: unnati-solanki-git <[email protected]>
Date:   Fri May 31 20:44:30 2024 +0530

    [minor] Merge health launcher into manage-is and re-organize some selenium tests (#999)

    Co-authored-by: Alexandre Quinteiro <[email protected]>
    Co-authored-by: Alexandre Quinteiro <[email protected]>

commit 3f10822
Author: Alona Varshal <[email protected]>
Date:   Thu May 30 04:21:42 2024 -0500

    [patch] Doc update for catalog guidance (#1005)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alequint alequint alequint approved these changes

@durera durera Awaiting requested review from durera durera is a code owner

@andrercm andrercm Awaiting requested review from andrercm andrercm is a code owner

@sanjayprab sanjayprab Awaiting requested review from sanjayprab sanjayprab is a code owner

@terenceq terenceq Awaiting requested review from terenceq terenceq is a code owner

@whitfiea whitfiea Awaiting requested review from whitfiea whitfiea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unnati-solanki-git @alequint