IBX-7051: Preview button with siteaccess #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
reviewed
Nov 20, 2023
lucasOsti
approved these changes
Nov 20, 2023
GrabowskiM
approved these changes
Nov 20, 2023
dew326
approved these changes
Nov 20, 2023
webhdx
approved these changes
Nov 20, 2023
konradoboza
reviewed
Nov 20, 2023
konradoboza
reviewed
Nov 20, 2023
konradoboza
approved these changes
Nov 20, 2023
| @@ -340,7 +349,7 @@ private function buildNode( | |||
| $children = []; | |||
| if ($loadChildren && $depth < $this->getSetting('tree_max_depth')) { | |||
| $searchResult = $this->findSubitems($location, $limit, $offset, $sortClause, $sortOrder); | |||
| $totalChildrenCount = $searchResult->totalCount; | |||
| $totalChildrenCount = (int) $searchResult->totalCount; | |||
There was a problem hiding this comment.
Suggested change
| $totalChildrenCount = (int) $searchResult->totalCount; | |
| $totalChildrenCount = $searchResult->totalCount === null ? 0 : (int)$searchResult->totalCount; |
tischsoic
force-pushed
the
IBX-7051-preview-btn-with-siteaccess
branch
from
450e330 to
f962ad1
Compare
|
SonarCloud Quality Gate failed.
|
|
@tischsoic have you evaluated Sonar Cloud bug report? |
|
I run regressions in: ibexa/headless#31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Checklist:
$ composer fix-cs)