Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] Disabled tests checking status of button hidden in the Context menu #1004

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Nov 23, 2023

This commit was part of #995 (450e330) , but then it got lost during the rebase process

There is a bug in context menu in AdminUI - reported as https://issues.ibexa.co/browse/IBX-7153

We will need to enable this tests (or adjust them) once it's fixed.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't the screenshots in the ticket suggest that "Create content" is also affected? 🙂

@mnocon
Copy link
Contributor Author

mnocon commented Nov 23, 2023

The same issue could occur, but it never does - this button does not get hidden in the Context menu.

Yesterday we've added the "Preview" button, which is second from the left - and it pushes the "Edit" button down to the context menu (there's no enough space).

We can keep the "Create" content test enabled - because it still tests that the button state is disabled in "normal" view

@micszo micszo merged commit 2171a1a into main Nov 23, 2023
22 of 23 checks passed
@micszo micszo deleted the disable-nested-button-test branch November 23, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants