Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @itwin/itwinui-react deps #2428

Merged
merged 9 commits into from
Feb 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .changeset/yellow-roses-know.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,7 @@
'@itwin/itwinui-react': minor
---

Bumped the minimum required version of `@tanstack/react-virtual` to `3.12.0`.
Bumped the minimum required versions of the following dependencies:
* `@tanstack/react-virtual` to `3.13.0`
* `@floating-ui/react` to `0.27.4`
* `classnames` to `2.5.1`
14 changes: 7 additions & 7 deletions packages/itwinui-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"clean:build": "rimraf esm && rimraf cjs && rimraf DEV-esm && rimraf DEV-cjs && rimraf styles.css",
"clean:coverage": "rimraf coverage",
"clean": "rimraf .turbo && pnpm clean:coverage && pnpm clean:build && rimraf node_modules",
"test": "pnpm test:types",
"test": "pnpm test:types && pnpm test:unit",
"test:unit": "vitest run",
"test:unit:watch": "pnpm test:unit --watch",
"test:types": "tsc -p tsconfig.test.json --noEmit",
Expand All @@ -103,17 +103,17 @@
"dev:styles": "pnpm build:styles --watch"
},
"dependencies": {
"@floating-ui/react": "^0.26.23",
"@floating-ui/react": "^0.27.4",
"@itwin/itwinui-illustrations-react": "^2.1.0",
"@swc/helpers": "^0.5.11",
"@tanstack/react-virtual": "^3.12.0",
"classnames": "^2.3.2",
"@swc/helpers": "^0.5.15",
"@tanstack/react-virtual": "^3.13.0",
"classnames": "^2.5.1",
"jotai": "^2.8.0",
"react-table": "^7.8.0"
},
"devDependencies": {
"@swc/cli": "^0.5.1",
"@swc/core": "^1.5.28",
"@swc/cli": "^0.6.0",
"@swc/core": "^1.10.15",
"@testing-library/jest-dom": "^6.6.3",
"@testing-library/react": "16.2.0",
"@testing-library/user-event": "^14.6.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/itwinui-react/src/core/Popover/Popover.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,8 @@ const PopoverPortal = ({
return (
<FloatingPortal
key={portalTo?.id} // workaround to force remount when `root` changes (see #2093)
root={portalTo}
// Don't pass `null` to FloatingPortal to ensure correct portaling (workaround for `floating-ui/[email protected]`+)
root={portalTo ?? undefined}
>
<DisplayContents />
{children}
Expand Down
Loading