Upgrade @itwin/itwinui-react deps
#2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r100-stack
requested review from
mayank99 and
smmr-dn
and removed request for
a team and
smmr-dn
mayank99
approved these changes
Feb 10, 2025
Update tanstack/react-virtual version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
After PR TODO from #2387.
Upgraded all dependencies of
@itwin/itwinui-reactexcept jotai (will be handled in another PR, as discussed). Also upgraded a few devDependencies.Upgrading floating ui caused many unit tests to fail. Upon investigating, this was because of a change in
FloatingPortal's behavior in@floating-ui/[email protected]. So, added a workaround inPopover.tsx.Readded the unit tests that seem to have been accidentally removed from the test script in #2387 😅. Just to be sure, re-confirmed that the unit tests were passing even before this PR.
Testing
Docs