Remove icons-generic (backport #1074) #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Removed a lot of dependencies on @bentley/icons-generic * Updated e2e tests to use relative path --------- Co-authored-by: GerardasB <[email protected]> (cherry picked from commit 2810fd0) # Conflicts: # common/config/rush/pnpm-lock.yaml # ui/appui-react/src/appui-react/statusfields/SectionsField.tsx # ui/components-react/package.json # ui/components-react/src/components-react/editors/EnumButtonGroupEditor.tsx
|
Cherry-pick of 2810fd0 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Merged
GerardasB
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removed several references to
@bentley/icons-genericby either reusing similar icons from@itwin/itwinui-iconsor inlining the icons directly.Testing
Verified the components with updated icons in the test app to ensure they function as expected.
This is an automatic backport of pull request #1074 done by [Mergify](https://mergify.com).