Remove icons-generic #1074
Merged
Remove icons-generic #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are still a few remaining files that use @bentley/icons-generic. However, since the SVGs are imported as strings, updating the component property types will be necessary to replace them. |
GerardasB
reviewed
Oct 16, 2024
ui/appui-react/src/appui-react/icons/AssetClassificationHide.tsx
Outdated
Show resolved
Hide resolved
ui/appui-react/src/appui-react/icons/AssetClassificationHide.tsx
Outdated
Show resolved
Hide resolved
GerardasB
approved these changes
Oct 23, 2024
ui/appui-react/src/appui-react/icons/AssetClassificationHide.tsx
Outdated
Show resolved
Hide resolved
FlyersPh9
reviewed
Oct 31, 2024
FlyersPh9
reviewed
Nov 5, 2024
ui/appui-react/src/appui-react/icons/SvgAssetClassificationHide.tsx
Outdated
Show resolved
Hide resolved
FlyersPh9
reviewed
Nov 5, 2024
FlyersPh9
reviewed
Nov 6, 2024
FlyersPh9
reviewed
Nov 6, 2024
FlyersPh9
reviewed
Nov 6, 2024
ui/appui-react/src/appui-react/icons/cube-faces/SvgCubeFaceBottom.tsx
Outdated
Show resolved
Hide resolved
FlyersPh9
approved these changes
Nov 6, 2024
|
@Mergifyio backport release/5.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 7, 2024
* Removed a lot of dependencies on @bentley/icons-generic * Updated e2e tests to use relative path --------- Co-authored-by: GerardasB <[email protected]> (cherry picked from commit 2810fd0) # Conflicts: # common/config/rush/pnpm-lock.yaml # ui/appui-react/src/appui-react/statusfields/SectionsField.tsx # ui/components-react/package.json # ui/components-react/src/components-react/editors/EnumButtonGroupEditor.tsx
GerardasB
added a commit
that referenced
this pull request
Dec 10, 2024
* Remove icons-generic (#1074) * Removed a lot of dependencies on @bentley/icons-generic * Updated e2e tests to use relative path --------- Co-authored-by: GerardasB <[email protected]> (cherry picked from commit 2810fd0) # Conflicts: # common/config/rush/pnpm-lock.yaml # ui/appui-react/src/appui-react/statusfields/SectionsField.tsx # ui/components-react/package.json # ui/components-react/src/components-react/editors/EnumButtonGroupEditor.tsx * Fix merge issues * Update NextVersion.md --------- Co-authored-by: MBudreviciusBentley <[email protected]> Co-authored-by: GerardasB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removed several references to
@bentley/icons-genericby either reusing similar icons from@itwin/itwinui-iconsor inlining the icons directly.Testing
Verified the components with updated icons in the test app to ensure they function as expected.